Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1309043004: Revert of Add a separate scope for switch (Closed)

Created:
5 years, 4 months ago by Dan Ehrenberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add a separate scope for switch (patchset #7 id:120001 of https://codereview.chromium.org/1293283002/ ) Reason for revert: Breaks cctest/test-cpu-profiler/SourceLocation on nosnap Original issue's description: > Add a separate scope for switch > > The ES2015 specification for switch statements 13.12.11 specifies that > they get their own lexical scope. This patch introduces such a scope > through a complex desugaring in terms of blocks, done so that Crankshaft > does not have to be updated to support multiple constructs providing > scopes. > > BUG=v8:4377 > LOG=Y > R=adamk > > Committed: https://crrev.com/9edbc1f21eb1050cabbe3b8bc9aebf89ada7ebd7 > Cr-Commit-Position: refs/heads/master@{#30314} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4377 Committed: https://crrev.com/31b801802997ed54117c7f2bc55f86e9e032cf3e Cr-Commit-Position: refs/heads/master@{#30316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -162 lines) Patch
M src/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parser.cc View 1 chunk +14 lines, -55 lines 0 comments Download
M src/scopes.h View 1 chunk +0 lines, -4 lines 0 comments Download
D test/mjsunit/regress/regress-4377.js View 1 chunk +0 lines, -45 lines 0 comments Download
M test/mjsunit/switch.js View 1 chunk +0 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Ehrenberg
Created Revert of Add a separate scope for switch
5 years, 4 months ago (2015-08-22 01:24:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309043004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309043004/1
5 years, 4 months ago (2015-08-22 01:24:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-22 01:24:27 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 01:24:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31b801802997ed54117c7f2bc55f86e9e032cf3e
Cr-Commit-Position: refs/heads/master@{#30316}

Powered by Google App Engine
This is Rietveld 408576698