content/browser/web_contents/web_contents_impl_unittest.cc - Issue 1309043003: Handle frame openers in the same FrameTree when navigating subframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 1309043003: Handle frame openers in the same FrameTree when navigating subframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@opener-cycle-detection

Patch Set: Add comment for the DCHECK Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl_unittest.cc

diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc

index 04e6fdd97f25c6c2212bac776e0a21881e63c35c..bcdc0921ee63619150acea7218c637934fbc3aa3 100644

--- a/content/browser/web_contents/web_contents_impl_unittest.cc

+++ b/content/browser/web_contents/web_contents_impl_unittest.cc

@@ -922,7 +922,7 @@ TEST_F(WebContentsImplTest, FindOpenerRVHWhenPending) {

scoped_ptr<TestWebContents> popup(

TestWebContents::Create(browser_context(), instance));

popup->SetOpener(contents());

- contents()->GetRenderManager()->CreateOpenerProxies(instance);

+ contents()->GetRenderManager()->CreateOpenerProxies(instance, nullptr);

// If swapped out is forbidden, a new proxy should be created for the opener

// in |instance|, and we should ensure that its routing ID is returned here.

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/test/data/post_message.html » ('j') | no next file with comments »