Issue 13090: Irregexp-ia32: Fixed backref-matching (works, and advances current position).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13090: Irregexp-ia32: Fixed backref-matching (works, and advances current position). (Closed)

Created:
12 years ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Matching a back-reference must handle unbound start-register (but can assume that if start register is bound, then end register is bound too). After matching a back reference, the character position is advanced past the match

Patch Set 1 #

Patch Set 2 : git diff master #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -13 lines)			Patch
M	src/interpreter-irregexp.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/jsregexp.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	1	2 chunks	+15 lines, -9 lines	0 comments	Download
M	test/cctest/test-regexp.cc	View		1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years ago (2008-12-03 13:09:34 UTC) #2

If you fix it so that current position is not advanced on a non-match then it
LGTM.

Expand Messages | Collapse Messages