Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1308993006: Disable RunMultiThread_DirectRenderer on Windows (Closed)

Created:
5 years, 3 months ago by pval...(no longer on Chromium)
Modified:
5 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable LayerTreeHostAnimationTestPendingTreeAnimatesFirstCommit BUG=527087 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4b7f32d2326449a03c7d5c171939ac0b349af257 Cr-Commit-Position: refs/heads/master@{#346738}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M cc/trees/layer_tree_host_unittest_animation.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pval...(no longer on Chromium)
5 years, 3 months ago (2015-09-01 20:40:10 UTC) #2
danakj
LGTM https://codereview.chromium.org/1308993006/diff/1/cc/trees/layer_tree_host_unittest_animation.cc File cc/trees/layer_tree_host_unittest_animation.cc (right): https://codereview.chromium.org/1308993006/diff/1/cc/trees/layer_tree_host_unittest_animation.cc#newcode934 cc/trees/layer_tree_host_unittest_animation.cc:934: // Flaky on Windows: http://crbug.com/527087 It would be ...
5 years, 3 months ago (2015-09-01 20:41:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308993006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308993006/20001
5 years, 3 months ago (2015-09-01 20:45:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308993006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308993006/20001
5 years, 3 months ago (2015-09-01 20:58:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 21:24:38 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4b7f32d2326449a03c7d5c171939ac0b349af257 Cr-Commit-Position: refs/heads/master@{#346738}
5 years, 3 months ago (2015-09-01 21:25:19 UTC) #11
danakj
5 years, 3 months ago (2015-09-01 22:06:57 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1308273009/ by danakj@chromium.org.

The reason for reverting is: Test is fixed..

Powered by Google App Engine
This is Rietveld 408576698