Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308983006: Don't drop type information returned from locateRenderSVGTextAncestor (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't drop type information returned from locateRenderSVGTextAncestor LayoutSVGText::locateRenderSVGTextAncestor returns a LayoutSVGText*, so widening it to LayoutObject only serves to lose information - for the primary benefit of "interface hiding". This in turn mean that some calls can be devirtualized. Also restructure the methods themselves to avoid stating the predicate twice (negated and not.) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201319

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 2

Patch Set 3 : Dedupe. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -25 lines) Patch
M Source/core/layout/svg/LayoutSVGInline.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGText.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGText.cpp View 1 2 2 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
fs
Trybot unhappiness unrelated.
5 years, 3 months ago (2015-08-26 18:25:28 UTC) #2
f(malita)
lgtm https://codereview.chromium.org/1308983006/diff/20001/Source/core/layout/svg/LayoutSVGText.cpp File Source/core/layout/svg/LayoutSVGText.cpp (right): https://codereview.chromium.org/1308983006/diff/20001/Source/core/layout/svg/LayoutSVGText.cpp#newcode83 Source/core/layout/svg/LayoutSVGText.cpp:83: return nullptr; Nit: instead of duplicating the impl ...
5 years, 3 months ago (2015-08-26 19:00:57 UTC) #3
fs
https://codereview.chromium.org/1308983006/diff/20001/Source/core/layout/svg/LayoutSVGText.cpp File Source/core/layout/svg/LayoutSVGText.cpp (right): https://codereview.chromium.org/1308983006/diff/20001/Source/core/layout/svg/LayoutSVGText.cpp#newcode83 Source/core/layout/svg/LayoutSVGText.cpp:83: return nullptr; On 2015/08/26 19:00:57, f(malita) wrote: > Nit: ...
5 years, 3 months ago (2015-08-27 10:25:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308983006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308983006/40001
5 years, 3 months ago (2015-08-27 11:05:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99372)
5 years, 3 months ago (2015-08-27 13:11:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308983006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308983006/40001
5 years, 3 months ago (2015-08-27 13:24:05 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 15:35:02 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201319

Powered by Google App Engine
This is Rietveld 408576698