Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 1308983005: NOT FOR LANDING Implement WebMediaSession (Closed)

Created:
5 years, 3 months ago by davve
Modified:
4 years, 10 months ago
CC:
avayvod+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR LANDING Implement WebMediaSession BUG=497735

Patch Set 1 #

Patch Set 2 : Actually initialize java object; indentation fixes #

Patch Set 3 : Hook-up of players and session begun #

Patch Set 4 : Beginnings of registering participants with sessions when a session is set #

Patch Set 5 : Nuke MediaSessionStandalone #

Patch Set 6 : Teach BrowserMediaPlayerManager about the presence of multiple MediaSessions #

Patch Set 7 : Rebase #

Patch Set 8 : Undo some renaming clutter for now #

Patch Set 9 : Add promise support and a test to go with it #

Patch Set 10 : Merge with CL introducing WebMediaSession #

Patch Set 11 : Rebased on top of https://codereview.chromium.org/1441883003/#ps220001 #

Patch Set 12 : Re-upload #

Patch Set 13 : Rebase #

Patch Set 14 : Rebase #

Patch Set 15 : Compile fix attempt for html_viewer #

Patch Set 16 : Add forward declaration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -73 lines) Patch
M chrome/browser/media/android/remote/remote_media_player_bridge.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +8 lines, -4 lines 0 comments Download
M components/html_viewer/html_frame.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -1 line 0 comments Download
M components/html_viewer/html_frame.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +4 lines, -2 lines 0 comments Download
M components/html_viewer/media_factory.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +4 lines, -2 lines 0 comments Download
M components/html_viewer/media_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/media/android/browser_media_player_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 10 chunks +28 lines, -20 lines 0 comments Download
M content/browser/media/android/browser_media_session_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +9 lines, -0 lines 0 comments Download
M content/browser/media/android/browser_media_session_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +56 lines, -3 lines 0 comments Download
M content/browser/media/android/media_session.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/media/android/media_session.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +32 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -2 lines 0 comments Download
M content/common/media/media_player_messages_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_session_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +7 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediasession_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -2 lines 0 comments Download
M media/base/android/media_codec_player.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M media/base/android/media_codec_player.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -2 lines 0 comments Download
M media/base/android/media_codec_player_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_player_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +7 lines, -1 line 0 comments Download
M media/base/android/media_player_android.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -2 lines 0 comments Download
M media/base/android/media_player_bridge.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M media/base/android/media_player_bridge.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +5 lines, -4 lines 0 comments Download
M media/base/android/media_player_bridge_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M media/base/android/media_source_player.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M media/base/android/media_source_player.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -2 lines 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +4 lines, -2 lines 0 comments Download
M media/blink/webmediaplayer_params.h View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +7 lines, -1 line 0 comments Download
M media/blink/webmediaplayer_params.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediasession/MediaSession.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
davve
Hi Anton, Mounir and Philip! While still rough, you may want to take a look ...
5 years, 3 months ago (2015-09-01 11:46:33 UTC) #3
davve
Have you had a chance of looking at the general direction here?
5 years, 3 months ago (2015-09-09 12:59:53 UTC) #4
mlamouri (slow - plz ping)
The design looks closer to what I was hoping for. I disagree on some details ...
5 years, 3 months ago (2015-09-15 14:50:07 UTC) #5
davve
Superseded by https://codereview.chromium.org/1441883003/
5 years, 1 month ago (2015-11-13 14:36:13 UTC) #6
davve
5 years ago (2015-12-09 15:26:03 UTC) #8
On 2015/11/13 14:36:13, David Vest wrote:
> Superseded by https://codereview.chromium.org/1441883003/

Re-opening. Will serve as a stash for experimental media session stuff a while
longer.

Powered by Google App Engine
This is Rietveld 408576698