Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1308983002: Add palmer as an OWNER of website_settings. (Closed)

Created:
5 years, 4 months ago by palmer
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tfarina, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add palmer as an OWNER of website_settings. Committed: https://crrev.com/807403855cbc9dca5cf5586c2d7f534918d828ba Cr-Commit-Position: refs/heads/master@{#345116}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove gbillock. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
A + chrome/browser/ui/cocoa/website_settings/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/website_settings/OWNERS View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/website_settings/OWNERS View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
palmer
I'm going to be doing more work on the Origin Info Bubble soon. PTAL!
5 years, 4 months ago (2015-08-21 22:10:29 UTC) #2
palmer
+markusheintz
5 years, 4 months ago (2015-08-21 22:12:54 UTC) #4
groby-ooo-7-16
As long as rsesek/felt are good with the OWNERS modification, adding an extra OWNERS in ...
5 years, 4 months ago (2015-08-21 22:13:41 UTC) #5
felt
https://codereview.chromium.org/1308983002/diff/1/chrome/browser/ui/website_settings/OWNERS File chrome/browser/ui/website_settings/OWNERS (right): https://codereview.chromium.org/1308983002/diff/1/chrome/browser/ui/website_settings/OWNERS#newcode7 chrome/browser/ui/website_settings/OWNERS:7: gbillock@chromium.org Can you remove gbillock?
5 years, 4 months ago (2015-08-21 22:22:34 UTC) #6
palmer
https://codereview.chromium.org/1308983002/diff/1/chrome/browser/ui/website_settings/OWNERS File chrome/browser/ui/website_settings/OWNERS (right): https://codereview.chromium.org/1308983002/diff/1/chrome/browser/ui/website_settings/OWNERS#newcode7 chrome/browser/ui/website_settings/OWNERS:7: gbillock@chromium.org On 2015/08/21 22:22:34, felt wrote: > Can you ...
5 years, 4 months ago (2015-08-21 22:46:54 UTC) #7
felt
lgtm
5 years, 4 months ago (2015-08-21 22:47:27 UTC) #8
markusheintz_
On 2015/08/21 22:47:27, felt wrote: > lgtm LGTM
5 years, 4 months ago (2015-08-24 08:48:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308983002/20001
5 years, 4 months ago (2015-08-24 14:10:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/60452) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 4 months ago (2015-08-24 14:14:04 UTC) #14
Robert Sesek
LGTM but please continue to get approval from a cocoa/ OWNERS for a style check
5 years, 4 months ago (2015-08-24 15:37:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308983002/20001
5 years, 4 months ago (2015-08-24 17:37:17 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 17:44:33 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 17:45:30 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/807403855cbc9dca5cf5586c2d7f534918d828ba
Cr-Commit-Position: refs/heads/master@{#345116}

Powered by Google App Engine
This is Rietveld 408576698