components/html_viewer/public/interfaces/layout_test_runner.mojom - Issue 1308973005: html_viewer/web_view: An app for running layout-tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/html_viewer/public/interfaces/layout_test_runner.mojom

Issue 1308973005: html_viewer/web_view: An app for running layout-tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix-win-build Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/html_viewer/public/interfaces/BUILD.gn ('k') | components/html_viewer/web_test_delegate_impl.cc » ('j') | components/view_manager/display_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 chrome.tabs.create({url: chrome.extension.getURL("page.html")});	5 module html_viewer;

	6

	7 interface LayoutTestRunner {
	sky 2015/09/03 19:31:59 Generally we put interfaces near the implementatio Generally we put interfaces near the implementation, not the call site. As LayoutTestRunner is implemented in test_runner, it shouldn't be here. Putting an interface here makes sense if html_viewer is going to implement it. sadrul 2015/09/03 19:47:44 I added it here since LayoutTestHTMLViewer in html Show quoted text On 2015/09/03 19:31:59, sky wrote: > Generally we put interfaces near the implementation, not the call site. As > LayoutTestRunner is implemented in test_runner, it shouldn't be here. Putting an > interface here makes sense if html_viewer is going to implement it. I added it here since LayoutTestHTMLViewer in html_viewer talks to it to notify it when the test finished. Or would it be OK to introduce a dependency on the test-runner (whether mandoline, or another dedicated app) to layout_test_html_viewer? sky 2015/09/03 19:52:24 I think the interface should belong with the test_ Show quoted text On 2015/09/03 19:47:44, sadrul wrote: > On 2015/09/03 19:31:59, sky wrote: > > Generally we put interfaces near the implementation, not the call site. As > > LayoutTestRunner is implemented in test_runner, it shouldn't be here. Putting > an > > interface here makes sense if html_viewer is going to implement it. > > I added it here since LayoutTestHTMLViewer in html_viewer talks to it to notify > it when the test finished. Or would it be OK to introduce a dependency on the > test-runner (whether mandoline, or another dedicated app) to > layout_test_html_viewer? I think the interface should belong with the test_runner.
	8 TestFinished();

	9 };

OLD	NEW