Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: runtime/vm/thread.cc

Issue 1308973003: - Really delete InterruptableThreadState. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Adjust more stuff. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/thread.h ('k') | runtime/vm/thread_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/thread.cc
diff --git a/runtime/vm/thread.cc b/runtime/vm/thread.cc
index dd9ba1174c9d22f41b351a17da0f18093dc79f67..3f0e3dcd48098eb66aeb9d67ce60131b9b8d9249 100644
--- a/runtime/vm/thread.cc
+++ b/runtime/vm/thread.cc
@@ -200,7 +200,8 @@ void Thread::EnterIsolateAsHelper(Isolate* isolate) {
thread->isolate()->store_buffer()->PopEmptyBlock();
ASSERT(isolate->heap() != NULL);
thread->heap_ = isolate->heap();
- ASSERT(thread->thread_state() == NULL);
+ ASSERT(thread->thread_interrupt_callback_ == NULL);
+ ASSERT(thread->thread_interrupt_data_ == NULL);
// Do not update isolate->mutator_thread, but perform sanity check:
// this thread should not be both the main mutator and helper.
ASSERT(!isolate->MutatorThreadIsCurrentThread());
@@ -215,7 +216,6 @@ void Thread::ExitIsolateAsHelper() {
thread->Unschedule();
// TODO(koda): Move store_buffer_block_ into State.
thread->StoreBufferRelease();
- thread->set_thread_state(NULL);
thread->isolate_ = NULL;
thread->heap_ = NULL;
ASSERT(!isolate->MutatorThreadIsCurrentThread());
« no previous file with comments | « runtime/vm/thread.h ('k') | runtime/vm/thread_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698