Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: runtime/include/dart_api.h

Issue 1308953007: Fix two memory leaks in SecureSocket. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/secure_socket.cc ('K') | « runtime/bin/secure_socket.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index 8b9070cfdad9ff34d6cc68fee3d8c32e958fb8a5..df7c7c3ea6825ffbe908cb40999691d78b1f0122 100755
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -475,8 +475,8 @@ DART_EXPORT void Dart_DeletePersistentHandle(Dart_PersistentHandle object);
* after the object is garbage collected, unless the handle has been deleted.
* A valid callback needs to be specified it cannot be NULL.
*
- * \return Success if the weak persistent handle was
- * created. Otherwise, returns an error.
+ * \return Returns the new weak persistent handle.
+ Returns NULL if and only if the callback is NULL.
Søren Gjesse 2015/09/02 16:24:31 Please check this with the VM team.
Bill Hesse 2015/09/03 08:47:00 They haven't looked at it, so removing it.
*/
DART_EXPORT Dart_WeakPersistentHandle Dart_NewWeakPersistentHandle(
Dart_Handle object,
« runtime/bin/secure_socket.cc ('K') | « runtime/bin/secure_socket.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698