Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1153)

Side by Side Diff: runtime/include/dart_api.h

Issue 1308953007: Fix two memory leaks in SecureSocket. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« runtime/bin/secure_socket.cc ('K') | « runtime/bin/secure_socket.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 2 * Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
3 * for details. All rights reserved. Use of this source code is governed by a 3 * for details. All rights reserved. Use of this source code is governed by a
4 * BSD-style license that can be found in the LICENSE file. 4 * BSD-style license that can be found in the LICENSE file.
5 */ 5 */
6 6
7 #ifndef INCLUDE_DART_API_H_ 7 #ifndef INCLUDE_DART_API_H_
8 #define INCLUDE_DART_API_H_ 8 #define INCLUDE_DART_API_H_
9 9
10 /** \mainpage Dart Embedding API Reference 10 /** \mainpage Dart Embedding API Reference
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
468 * 468 *
469 * \param object An object. 469 * \param object An object.
470 * \param peer A pointer to a native object or NULL. This value is 470 * \param peer A pointer to a native object or NULL. This value is
471 * provided to callback when it is invoked. 471 * provided to callback when it is invoked.
472 * \param external_allocation_size The number of externally allocated 472 * \param external_allocation_size The number of externally allocated
473 * bytes for peer. Used to inform the garbage collector. 473 * bytes for peer. Used to inform the garbage collector.
474 * \param callback A function pointer that will be invoked sometime 474 * \param callback A function pointer that will be invoked sometime
475 * after the object is garbage collected, unless the handle has been deleted. 475 * after the object is garbage collected, unless the handle has been deleted.
476 * A valid callback needs to be specified it cannot be NULL. 476 * A valid callback needs to be specified it cannot be NULL.
477 * 477 *
478 * \return Success if the weak persistent handle was 478 * \return Returns the new weak persistent handle.
479 * created. Otherwise, returns an error. 479 Returns NULL if and only if the callback is NULL.
Søren Gjesse 2015/09/02 16:24:31 Please check this with the VM team.
Bill Hesse 2015/09/03 08:47:00 They haven't looked at it, so removing it.
480 */ 480 */
481 DART_EXPORT Dart_WeakPersistentHandle Dart_NewWeakPersistentHandle( 481 DART_EXPORT Dart_WeakPersistentHandle Dart_NewWeakPersistentHandle(
482 Dart_Handle object, 482 Dart_Handle object,
483 void* peer, 483 void* peer,
484 intptr_t external_allocation_size, 484 intptr_t external_allocation_size,
485 Dart_WeakPersistentHandleFinalizer callback); 485 Dart_WeakPersistentHandleFinalizer callback);
486 486
487 DART_EXPORT void Dart_DeleteWeakPersistentHandle( 487 DART_EXPORT void Dart_DeleteWeakPersistentHandle(
488 Dart_Isolate isolate, 488 Dart_Isolate isolate,
489 Dart_WeakPersistentHandle object); 489 Dart_WeakPersistentHandle object);
(...skipping 2363 matching lines...) Expand 10 before | Expand all | Expand 10 after
2853 2853
2854 /** 2854 /**
2855 * Returns the port that script load requests should be sent on. 2855 * Returns the port that script load requests should be sent on.
2856 * 2856 *
2857 * \return Returns the port for load requests or ILLEGAL_PORT if the service 2857 * \return Returns the port for load requests or ILLEGAL_PORT if the service
2858 * isolate failed to startup or does not support load requests. 2858 * isolate failed to startup or does not support load requests.
2859 */ 2859 */
2860 DART_EXPORT Dart_Port Dart_ServiceWaitForLoadPort(); 2860 DART_EXPORT Dart_Port Dart_ServiceWaitForLoadPort();
2861 2861
2862 #endif /* INCLUDE_DART_API_H_ */ /* NOLINT */ 2862 #endif /* INCLUDE_DART_API_H_ */ /* NOLINT */
OLDNEW
« runtime/bin/secure_socket.cc ('K') | « runtime/bin/secure_socket.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698