Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1308953006: Revert of Add apktool and apktool.jar to install-build-deps-android.sh (Closed)

Created:
5 years, 3 months ago by navabi
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add apktool and apktool.jar to install-build-deps-android.sh (patchset #4 id:60001 of https://codereview.chromium.org/1287133002/ ) Reason for revert: Chromium devs don't have gsutil or gsutil credentials. install-build-deps-android.sh should be usable by public chromium developers. Also, apktool has since been checked into the chromium checkout, so we no longer even need this. Original issue's description: > Add apktool and apktool.jar to install-build-deps-android.sh > > BUG=452927 > TBR=cjhopman@chromium.org > > Committed: https://crrev.com/28978226297bc33a6ca73efb1a82271888a5a8fb > Cr-Commit-Position: refs/heads/master@{#343269} TBR=dba@chromium.org,friedman@chromium.org,luqui@chromium.org,cjhopman@chromium.org,johnw@google.com,pschmidt@google.com,hinoka@chromium.org,kerz@chromium.org,hinoka@google.com,navabi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=452927 Committed: https://crrev.com/b1df3cb9b1af7ed831d8d4b28cf388b4c9421c50 Cr-Commit-Position: refs/heads/master@{#346478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M build/install-build-deps-android.sh View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
navabi
Created Revert of Add apktool and apktool.jar to install-build-deps-android.sh
5 years, 3 months ago (2015-08-29 23:45:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308953006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308953006/1
5 years, 3 months ago (2015-08-29 23:45:48 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-08-29 23:45:49 UTC) #4
ghost stip (do not use)
lgtm
5 years, 3 months ago (2015-08-31 21:43:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308953006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308953006/1
5 years, 3 months ago (2015-08-31 21:43:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 21:45:31 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 21:46:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1df3cb9b1af7ed831d8d4b28cf388b4c9421c50
Cr-Commit-Position: refs/heads/master@{#346478}

Powered by Google App Engine
This is Rietveld 408576698