Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2120)

Unified Diff: Source/modules/netinfo/NetworkInformation.h

Issue 1308943005: [NetInfo] Add Blink support for connection.change, connection.downlinkMax, and wimax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update test expectations Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/netinfo/NetworkInformation.h
diff --git a/Source/modules/netinfo/NetworkInformation.h b/Source/modules/netinfo/NetworkInformation.h
index 5369e568880d7c07b4a751bf15753539c82ce789..a9d9ee79bc858137d9480f0ae61bef768068f95f 100644
--- a/Source/modules/netinfo/NetworkInformation.h
+++ b/Source/modules/netinfo/NetworkInformation.h
@@ -26,8 +26,10 @@ public:
~NetworkInformation() override;
String type() const;
+ double downlinkMax() const;
- void connectionTypeChange(WebConnectionType) override;
+ // NetworkStateObserver overrides.
+ void connectionChange(WebConnectionType, double) override;
adamk 2015/08/28 00:55:31 Same bit here about naming
jkarlin 2015/09/02 17:37:07 Done.
// EventTarget overrides.
const AtomicString& interfaceName() const override;
@@ -42,7 +44,8 @@ public:
DECLARE_VIRTUAL_TRACE();
- DEFINE_ATTRIBUTE_EVENT_LISTENER(typechange);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(change);
+ DEFINE_ATTRIBUTE_EVENT_LISTENER(typechange); // Deprecated
private:
explicit NetworkInformation(ExecutionContext*);
@@ -52,6 +55,9 @@ private:
// Touched only on context thread.
WebConnectionType m_type;
+ // Touched only on context thread.
+ double m_downlinkMax;
+
// Whether this object is listening for events from NetworkStateNotifier.
bool m_observing;

Powered by Google App Engine
This is Rietveld 408576698