Source/core/testing/Internals.h - Issue 1308943005: [NetInfo] Add Blink support for connection.change, connection.downlinkMax, and wimax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/Internals.h

Issue 1308943005: [NetInfo] Add Blink support for connection.change, connection.downlinkMax, and wimax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update test expectations Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/page/NetworkStateNotifier.h ('K') | « Source/core/page/NetworkStateNotifierTest.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | Source/modules/netinfo/NetworkInformation.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/testing/Internals.h

diff --git a/Source/core/testing/Internals.h b/Source/core/testing/Internals.h

index f90376825d2bfd0dd279c1a1b4c11416311a4b0b..9095fe159aa38a22fffedf0d68ef4bd43aeda76b 100644

--- a/Source/core/testing/Internals.h

+++ b/Source/core/testing/Internals.h

@@ -337,9 +337,10 @@ public:

bool ignoreLayoutWithPendingStylesheets(Document*);

+ // Test must call setNetworkStateNotifierTestOnly(true) before calling setNetworkConnectionInfo or

+ // setNetworkStateMaxBandwidth.

void setNetworkStateNotifierTestOnly(bool);

- // Test must call setNetworkStateNotifierTestOnly(true) before calling setNetworkConnectionInfo.

- void setNetworkConnectionInfo(const String&, ExceptionState&);

+ void setNetworkConnectionInfo(const String&, double downlinkMax, ExceptionState&);

ClientRect* boundsInViewportSpace(Element*);