Issue 130893009: Don't animate child windows if animations are disabled in Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130893009: Don't animate child windows if animations are disabled in Windows. (Closed)

Created:
6 years, 10 months ago by ananta

Modified:
6 years, 10 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+corewm_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Don't animate child windows if animations are disabled in Windows. BUG=338413 R=sky@chromium.org, sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248630

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	ui/views/corewm/window_animations.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/130893009/diff/180001/ui/views/corewm/window_animations.cc File ui/views/corewm/window_animations.cc (right): https://codereview.chromium.org/130893009/diff/180001/ui/views/corewm/window_animations.cc#newcode571 ui/views/corewm/window_animations.cc:571: if (!gfx::Animation::ShouldRenderRichAnimation()) nit: combine into single return statement.

6 years, 10 months ago (2014-02-03 04:40:46 UTC) #2

ananta

https://codereview.chromium.org/130893009/diff/180001/ui/views/corewm/window_animations.cc File ui/views/corewm/window_animations.cc (right): https://codereview.chromium.org/130893009/diff/180001/ui/views/corewm/window_animations.cc#newcode571 ui/views/corewm/window_animations.cc:571: if (!gfx::Animation::ShouldRenderRichAnimation()) On 2014/02/03 04:40:46, sky wrote: > nit: ...

6 years, 10 months ago (2014-02-03 19:51:07 UTC) #3

ananta

6 years, 10 months ago (2014-02-04 00:29:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r248630 (presubmit successful).

Expand Messages | Collapse Messages

Issue 130893009: Don't animate child windows if animations are disabled in Windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages