Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 130893006: Remove another now-unnecessary msvs_cygwin_shell:1 (Closed)

Created:
6 years, 11 months ago by scottmg
Modified:
6 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Remove another now-unnecessary msvs_cygwin_shell:1 Was another workaround for escaping arguments, no longer needed in ninja-only world. R=thakis@chromium.org BUG=123026 TEST=ninja -C out\Debug mini_installer Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247650

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/installer/mini_installer.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
scottmg
6 years, 11 months ago (2014-01-24 21:19:54 UTC) #1
Nico
lgtm
6 years, 11 months ago (2014-01-24 21:25:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/130893006/1
6 years, 11 months ago (2014-01-24 21:31:21 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=251603
6 years, 11 months ago (2014-01-24 22:51:40 UTC) #4
scottmg
On 2014/01/24 22:51:40, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 11 months ago (2014-01-24 23:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/130893006/1
6 years, 10 months ago (2014-01-29 03:23:53 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) remoting_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=217750
6 years, 10 months ago (2014-01-29 04:18:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/130893006/1
6 years, 10 months ago (2014-01-29 04:40:19 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 06:39:07 UTC) #9
Message was sent while issue was closed.
Change committed as 247650

Powered by Google App Engine
This is Rietveld 408576698