Revert 243957 "Enable SDCH support over HTTPS if --enable-sdch=2..."

Revert 243957 "Enable SDCH support over HTTPS if --enable-sdch=2..."

> Enable SDCH support over HTTPS if --enable-sdch=2 switch is present.
> 
> BUG=313716
> 
> Review URL: https://codereview.chromium.org/123383002

TBR=mef@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244038

[Noam Samuel, 2014-01-10 01:54:33]

Committed patchset #1 manually as r244038.

[mef, 2014-01-10 15:15:28]

Hi Noam,

could you elaborate on reason to revert?
I can't seem to find a failure pointing to my CL.

thanks,
-m


On Thu, Jan 9, 2014 at 8:54 PM, <noamsml@chromium.org> wrote:

> Reviewers: mef,
>
> Description:
> Revert 243957 "Enable SDCH support over HTTPS if --enable-sdch=2..."
>
>  Enable SDCH support over HTTPS if --enable-sdch=2 switch is present.
>>
>
>  BUG=313716
>>
>
>  Review URL: https://codereview.chromium.org/123383002
>>
>
> TBR=mef@chromium.org
>
> Please review this at https://codereview.chromium.org/130893005/
>
> SVN Base: svn://svn.chromium.org/chrome/
>
> Affected files (+13, -127 lines):
>   M     trunk/src/chrome/browser/chrome_browser_main.cc
>   M     trunk/src/net/base/sdch_filter_unittest.cc
>   M     trunk/src/net/base/sdch_manager.h
>   M     trunk/src/net/base/sdch_manager.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Noam Samuel (WRONG ACCOUNT), 2014-01-10 17:28:58]

Hey, this revert was intended to stop net_unittest failures here:
http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29....
However, it seems to not have been needed:
http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29...
was not on the blamelist), so I think the CL should be relanded.


On Fri, Jan 10, 2014 at 7:15 AM, Misha Efimov <mef@chromium.org> wrote:

> Hi Noam,
>
> could you elaborate on reason to revert?
> I can't seem to find a failure pointing to my CL.
>
> thanks,
> -m
>
>
> On Thu, Jan 9, 2014 at 8:54 PM, <noamsml@chromium.org> wrote:
>
>> Reviewers: mef,
>>
>> Description:
>> Revert 243957 "Enable SDCH support over HTTPS if --enable-sdch=2..."
>>
>>  Enable SDCH support over HTTPS if --enable-sdch=2 switch is present.
>>>
>>
>>  BUG=313716
>>>
>>
>>  Review URL: https://codereview.chromium.org/123383002
>>>
>>
>> TBR=mef@chromium.org
>>
>> Please review this at https://codereview.chromium.org/130893005/
>>
>> SVN Base: svn://svn.chromium.org/chrome/
>>
>> Affected files (+13, -127 lines):
>>   M     trunk/src/chrome/browser/chrome_browser_main.cc
>>   M     trunk/src/net/base/sdch_filter_unittest.cc
>>   M     trunk/src/net/base/sdch_manager.h
>>   M     trunk/src/net/base/sdch_manager.cc
>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.