Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1308913003: Re-land: Enable GpuMemoryBuffers video frames on MacOS. (Closed)

Created:
5 years, 4 months ago by Daniele Castagna
Modified:
5 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, oshima+watch_chromium.org, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Enable GpuMemoryBuffers video frames on MacOS. This patch enables UYVY GpuMemoryBuffers backed VideoFrames on MacOSX for software decoded videos. This change allows VideoLayers to be promoted to overlays when possible. Power measurements showed a significant reduction in Watts consumed during video playback: in the tests ran by ccameron@ it went from 3.15 Watts to 2.13 Watts. Additionally this change avoids one copy of the VideoFrame in the GPU process and moves away another copy from the Compositor thread to media. Unfortunately, for videos where the decoding time is close to the frame time, the additional copy might slow down the decoding past the limit, causing more dropped frames in these cases. More benchmark results can be found here: https://x20web.corp.google.com/~dcastagna/results_all.html The first run is with GMB video frames disabled, the second one, enabled. BUG=485859, 510252 Committed: https://crrev.com/96463459619f441a721f96c51c357208604b7475 Cr-Commit-Position: refs/heads/master@{#345418} Committed: https://crrev.com/b65e607913fe32132494e877bc1b70108e4d0e20 Cr-Commit-Position: refs/heads/master@{#347566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (6 generated)
Daniele Castagna
5 years, 4 months ago (2015-08-21 20:51:56 UTC) #2
ccameron
This lgtm -- I think we should try to enable for M46 branch point.
5 years, 4 months ago (2015-08-21 21:00:46 UTC) #3
Andre
LGTM
5 years, 4 months ago (2015-08-21 21:10:20 UTC) #4
Avi (use Gerrit)
content lgtm
5 years, 4 months ago (2015-08-21 21:34:24 UTC) #6
Daniele Castagna
+avi for content/ Thank you Avi! :)
5 years, 4 months ago (2015-08-21 21:35:07 UTC) #7
Daniele Castagna
+piman for chrome/browser/chromeos/login
5 years, 4 months ago (2015-08-21 21:44:39 UTC) #9
piman
lgtm
5 years, 4 months ago (2015-08-21 23:50:25 UTC) #10
DaleCurtis
lgtm
5 years, 4 months ago (2015-08-25 18:59:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308913003/1
5 years, 4 months ago (2015-08-25 19:03:57 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-25 20:10:44 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/96463459619f441a721f96c51c357208604b7475 Cr-Commit-Position: refs/heads/master@{#345418}
5 years, 3 months ago (2015-08-25 20:11:25 UTC) #16
mnaganov (inactive)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1313123008/ by mnaganov@chromium.org. ...
5 years, 3 months ago (2015-08-25 23:29:59 UTC) #17
Daniele Castagna
On 2015/08/25 at 23:29:59, mnaganov wrote: > A revert of this CL (patchset #1 id:1) ...
5 years, 3 months ago (2015-09-05 06:03:40 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308913003/1
5 years, 3 months ago (2015-09-05 06:03:54 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-05 07:18:51 UTC) #21
commit-bot: I haz the power
5 years, 3 months ago (2015-09-05 07:19:45 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b65e607913fe32132494e877bc1b70108e4d0e20
Cr-Commit-Position: refs/heads/master@{#347566}

Powered by Google App Engine
This is Rietveld 408576698