[MD Extensions] Move search field out of downloads, use it in extensions

chrome/browser/resources/md_downloads/toolbar.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('downloads', function() {
   var Toolbar = Polymer({
     is: 'downloads-toolbar',
 
     /** @param {!downloads.ActionService} actionService */
     setActionService: function(actionService) {
       /** @private {!downloads.ActionService} */
       this.actionService_ = actionService;
     },
 
+    attached: function() {
+      /** @private {!SearchField.Delegate} */
+      this.searchFieldDelegate_ = new ToolbarSearchFieldDelegate(this);
+      this.$['search-input'].setDelegate(this.searchFieldDelegate_);
+    },
+
     properties: {
       downloadsShowing: {
         reflectToAttribute: true,
         type: Boolean,
         value: false,
         observer: 'onDownloadsShowingChange_',
       },
-
-      showingSearch_: {
-        type: Boolean,
-        value: false,
-      },
     },
 
     /** @return {boolean} Whether removal can be undone. */
     canUndo: function() {
       return this.$['search-input'] != this.shadowRoot.activeElement;
     },
 
     /** @return {boolean} Whether "Clear all" should be allowed. */
     canClearAll: function() {
-      return !this.$['search-input'].value && this.downloadsShowing;
+      return !this.$['search-input'].getValue() && this.downloadsShowing;
     },
 
     /** @private */
     onClearAllClick_: function() {
       assert(this.canClearAll());
       this.actionService_.clearAll();
     },
 
     /** @private */
     onDownloadsShowingChange_: function() {
       this.updateClearAll_();
     },
 
-    /** @private */
-    onSearchTermSearch_: function() {
-      this.actionService_.search(this.$['search-input'].value);
+    /**
+     * @param {string} value

[Dan Beam, 2015/09/14 23:16:06]

nit: /** @param {string} ... */ if it fits in one line

[Dan Beam, 2015/09/14 23:16:06]

nit: value -> searchText

[Devlin, 2015/09/15 17:24:06]

Done.

[Devlin, 2015/09/15 17:24:06]

Done.

+     */
+    onSearchTermSearch: function(value) {
+      this.actionService_.search(value);
       this.updateClearAll_();
     },
 
     /** @private */
-    onSearchTermKeydown_: function(e) {
-      assert(this.showingSearch_);
-      if (e.keyIdentifier == 'U+001B')  // Escape.
-        this.toggleShowingSearch_();
-    },
-
-    /** @private */
     onOpenDownloadsFolderClick_: function() {
       this.actionService_.openDownloadsFolder();
     },
 
     /** @private */
-    toggleShowingSearch_: function() {
-      this.showingSearch_ = !this.showingSearch_;
-      this.$['search-button'].disabled = this.showingSearch_;
-
-      if (this.showingSearch_) {
-        this.$['search-input'].focus();
-      } else {
-        this.$['search-input'].value = '';
-        this.onSearchTermSearch_();
-      }
-    },
-
-    /** @private */
     updateClearAll_: function() {
       this.$$('#actions .clear-all').hidden = !this.canClearAll();
       this.$$('paper-menu .clear-all').hidden = !this.canClearAll();
     },
   });
 
+  /**
+   * @constructor
+   * @implements {SearchField.Delegate}
+   */
+  function ToolbarSearchFieldDelegate(toolbar) {
+    this.toolbar_ = toolbar;
+  }
+
+  ToolbarSearchFieldDelegate.prototype = {
+    /** @override */
+    onSearchTermSearch: function(value) {

[Dan Beam, 2015/09/14 23:16:06]

can downloads.Toolbar just implement SearchField.Delegate directly?

[Dan Beam, 2015/09/14 23:52:54]

safe to ignore if this isn't currently feasible

+      this.toolbar_.onSearchTermSearch(value);
+    }
+  };
+
   return {Toolbar: Toolbar};
 });
 
 // TODO(dbeam): https://github.com/PolymerElements/iron-dropdown/pull/16/files
 /** @suppress {checkTypes} */
 (function() {
 Polymer.IronDropdownScrollManager.pushScrollLock = function() {};
 })();