Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 1308873003: Set "use_openssl" gyp variable to 1 if it is undefined (Closed)

Created:
5 years, 4 months ago by Satoshi Matsumoto
Modified:
5 years, 4 months ago
Reviewers:
tkchin, jiayl, juberti2
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libsrtp.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set "use_openssl" gyp variable to 1 if it is undefined This CL is needed to build WebRTC without linking to BoringSSL with use_openssl=0 in GYP_DEFINES. BUG= R=jiayl@chromium.org, tkchin@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libsrtp/+/e1f6929624dd785cff493e39ab4932b955028e5c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M libsrtp.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Satoshi Matsumoto
5 years, 4 months ago (2015-08-22 08:22:24 UTC) #2
juberti1
On 2015/08/22 08:22:24, Satoshi Matsumoto wrote: I forget the GYP syntax; Jiayang/Zeke, can you take ...
5 years, 4 months ago (2015-08-24 23:31:47 UTC) #4
jiayl
lgtm
5 years, 4 months ago (2015-08-24 23:45:59 UTC) #5
tkchin
On 2015/08/24 23:31:47, juberti1 wrote: > On 2015/08/22 08:22:24, Satoshi Matsumoto wrote: > > I ...
5 years, 4 months ago (2015-08-24 23:47:31 UTC) #6
tkchin
On 2015/08/24 23:47:31, tkchin wrote: > On 2015/08/24 23:31:47, juberti1 wrote: > > On 2015/08/22 ...
5 years, 4 months ago (2015-08-25 00:55:29 UTC) #8
jiayl
5 years, 4 months ago (2015-08-25 16:56:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1f6929624dd785cff493e39ab4932b955028e5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698