Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1308863002: [Eraser strings] Remove flag to disable WebRTC on Android. (Closed)

Created:
5 years, 4 months ago by tommi (sloooow) - chröme
Modified:
5 years, 4 months ago
Reviewers:
Niklas Enbom, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Eraser strings] Remove flag to disable WebRTC on Android. This flag was added years ago while we were catching up to Chrome on Desktop. Also removes related strings. See also related cl when WebRTC was enabled by default on Android: https://src.chromium.org/viewvc/chrome?revision=188095&view=revision BUG=190313 Committed: https://crrev.com/18dc5c50f35126d9f6310326fa2f450967bdd819 Cr-Commit-Position: refs/heads/master@{#344936}

Patch Set 1 #

Patch Set 2 : Include generated_resources.grd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308863002/1
5 years, 4 months ago (2015-08-21 16:28:28 UTC) #2
tommi (sloooow) - chröme
5 years, 4 months ago (2015-08-21 16:36:32 UTC) #4
Niklas Enbom
Shouldn't we delete the entry in chrome/app/generated_resources.grd as well? On 2015/08/21 16:36:32, tommi wrote:
5 years, 4 months ago (2015-08-21 16:47:49 UTC) #5
tommi (sloooow) - chröme
Include generated_resources.grd
5 years, 4 months ago (2015-08-21 16:50:16 UTC) #6
tommi (sloooow) - chröme
On 2015/08/21 16:47:49, Niklas Enbom wrote: > Shouldn't we delete the entry in chrome/app/generated_resources.grd as ...
5 years, 4 months ago (2015-08-21 16:50:24 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308863002/20001
5 years, 4 months ago (2015-08-21 16:52:07 UTC) #9
Niklas Enbom
lgtm On 2015/08/21 16:52:07, commit-bot: I haz the power wrote: > Dry run: CQ is ...
5 years, 4 months ago (2015-08-21 17:28:00 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/59823)
5 years, 4 months ago (2015-08-21 17:48:34 UTC) #12
Niklas Enbom
piman for OWNERS review
5 years, 4 months ago (2015-08-21 18:11:41 UTC) #14
piman
lgtm
5 years, 4 months ago (2015-08-21 23:49:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308863002/20001
5 years, 4 months ago (2015-08-22 00:01:04 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-22 00:29:11 UTC) #18
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 00:30:26 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18dc5c50f35126d9f6310326fa2f450967bdd819
Cr-Commit-Position: refs/heads/master@{#344936}

Powered by Google App Engine
This is Rietveld 408576698