Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1308853008: Release Media Router Action icon when dialog closed. (Closed)

Created:
5 years, 3 months ago by apacible
Modified:
5 years, 3 months ago
Reviewers:
imcheng, Peter Kasting
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release Media Router Action icon when dialog closed. Currently, when the initiator WebContents is destroyed, the controller is reset. We don't release the action icon when Reset() is called, meaning the icon stays pressed down until the user tabs away and back. This change releases the action icon immediately when Reset() is called. BUG=528422 Committed: https://crrev.com/2800acc52631edae823f59b798ae48fb0203f4f1 Cr-Commit-Position: refs/heads/master@{#347520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/ui/toolbar/media_router_action_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
apacible
PTAL, thanks! +pkasting for chrome/browser/ui/toolbar/ +imcheng for chrome/browser/ui/webui/media_router/
5 years, 3 months ago (2015-09-04 20:39:46 UTC) #2
imcheng
lgtm
5 years, 3 months ago (2015-09-04 21:01:13 UTC) #3
Peter Kasting
LGTM
5 years, 3 months ago (2015-09-04 22:50:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308853008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308853008/1
5 years, 3 months ago (2015-09-04 22:59:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-04 23:06:09 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-04 23:06:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2800acc52631edae823f59b798ae48fb0203f4f1
Cr-Commit-Position: refs/heads/master@{#347520}

Powered by Google App Engine
This is Rietveld 408576698