Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1308853003: 2D Canvas: disable rendering deferral in cases with a lot of overdraw (Closed)

Created:
5 years, 4 months ago by Justin Novosad
Modified:
5 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, dshwang, jbroman, Justin Novosad, danakj, Rik, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

2D Canvas: disable rendering deferral in cases with a lot of overdraw Accumulating large draw command backlogs can result in janky performance, and in extreme cases, a GPU denial of service. This change fixes that problem by disabling deferred rendering when high overdraw is detected. Cases where the overdraw overwrites the entire canvas are not affected by this change and will stay in deferred rendering mode because overwriting the entire canvas resets the backlog. BUG=522764, 522972 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Source/platform/graphics/Canvas2DImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/graphics/Canvas2DLayerBridge.cpp View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Justin Novosad
PTAL
5 years, 4 months ago (2015-08-21 18:31:21 UTC) #2
Stephen White
LGTM
5 years, 4 months ago (2015-08-21 19:16:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308853003/1
5 years, 4 months ago (2015-08-21 19:24:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/59145)
5 years, 4 months ago (2015-08-21 22:33:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308853003/1
5 years, 4 months ago (2015-08-22 01:32:07 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 03:34:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201036

Powered by Google App Engine
This is Rietveld 408576698