Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/browser/chromeos/first_run/goodies_displayer.h

Issue 1308833004: Show Goodies page to new Chromebook users (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use LazyInstance<GoodiesDisplayer> Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_CHROMEOS_FIRST_RUN_GOODIES_DISPLAYER_H_
6 #define CHROME_BROWSER_CHROMEOS_FIRST_RUN_GOODIES_DISPLAYER_H_
7
8 #include "chrome/browser/ui/browser_list.h"
9 #include "chrome/browser/ui/browser_list_observer.h"
10
11 namespace chromeos {
12 namespace first_run {
13
14 #if defined(OS_CHROMEOS)
achuithb 2015/09/15 18:20:54 Pretty sure you don't need this - gyp file should
Greg Levin 2015/09/15 21:44:48 Yep, good call!
15
16 // Handles display of OOBE Goodies page on first display of browser window on
17 // new Chromebooks.
18 class GoodiesDisplayer : public chrome::BrowserListObserver {
19 public:
20 GoodiesDisplayer();
21
22 ~GoodiesDisplayer() override {}
23
24 void OnBrowserSetLastActive(Browser* browser) override;
achuithb 2015/09/15 18:20:54 Add comment like: // BrowserListObserver overrides
Greg Levin 2015/09/15 21:44:48 Done.
25
26 DISALLOW_COPY_AND_ASSIGN(GoodiesDisplayer);
27 };
28
29 #endif // defined(OS_CHROMEOS)
30
31 void InitializeGoodiesDisplayer();
achuithb 2015/09/15 18:20:54 Make this a static member of GoodiesDisplayer, and
Greg Levin 2015/09/15 21:44:48 Done.
32
33 } // namespace first_run
34 } // namespace chromeos
35
36 #endif // CHROME_BROWSER_CHROMEOS_FIRST_RUN_GOODIES_DISPLAYER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698