Show Goodies page to new Chromebook users

chrome/browser/chromeos/login/startup_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/startup_utils.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/path_service.h"
@@ skipping 69 matching lines @@
   // Forcing the second pref will force this one as well. Even if this one
   // doesn't end up synced it is only going to eat up a couple of bytes with no
   // side-effects.
   g_browser_process->local_state()->ClearPref(prefs::kOobeScreenPending);
   SaveBoolPreferenceForced(prefs::kOobeComplete, true);
 
   // Successful enrollment implies that recovery is not required.
   SaveBoolPreferenceForced(prefs::kEnrollmentRecoveryRequired, false);
 }
 
+// static
 void StartupUtils::SaveOobePendingScreen(const std::string& screen) {
   SaveStringPreferenceForced(prefs::kOobeScreenPending, screen);
 }
 
 // Returns the path to flag file indicating that both parts of OOBE were
 // completed.
 // On chrome device, returns /home/chronos/.oobe_completed.
 // On Linux desktop, returns {DIR_USER_DATA}/.oobe_completed.
 static base::FilePath GetOobeCompleteFlagPath() {
   // The constant is defined here so it won't be referenced directly.
   const char kOobeCompleteFlagFilePath[] = "/home/chronos/.oobe_completed";
 
   if (base::SysInfo::IsRunningOnChromeOS()) {
     return base::FilePath(kOobeCompleteFlagFilePath);
   } else {
     base::FilePath user_data_dir;
     PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
     return user_data_dir.AppendASCII(".oobe_completed");
   }
 }
 
+// static
+base::TimeDelta StartupUtils::GetTimeSinceOobeFlagFileCreation() {
+  const base::FilePath oobe_complete_flag_path = GetOobeCompleteFlagPath();
+  base::File::Info file_info;
+  if (base::GetFileInfo(oobe_complete_flag_path, &file_info))
+    return base::Time::Now() - file_info.creation_time;
+  return base::TimeDelta();
+}
+
 static void CreateOobeCompleteFlagFile() {
   // Create flag file for boot-time init scripts.
-  base::FilePath oobe_complete_path = GetOobeCompleteFlagPath();
-  if (!base::PathExists(oobe_complete_path)) {
-    FILE* oobe_flag_file = base::OpenFile(oobe_complete_path, "w+b");
+  const base::FilePath oobe_complete_flag_path = GetOobeCompleteFlagPath();
+  if (!base::PathExists(oobe_complete_flag_path)) {
+    FILE* oobe_flag_file = base::OpenFile(oobe_complete_flag_path, "w+b");
     if (oobe_flag_file == NULL)
-      DLOG(WARNING) << oobe_complete_path.value() << " doesn't exist.";
+      DLOG(WARNING) << oobe_complete_flag_path.value() << " doesn't exist.";
     else
       base::CloseFile(oobe_flag_file);
   }
 }
 
 // static
 bool StartupUtils::IsDeviceRegistered() {
   int value =
       g_browser_process->local_state()->GetInteger(prefs::kDeviceRegistered);
   if (value > 0) {
     // Recreate flag file in case it was lost.
     BrowserThread::PostTask(
         BrowserThread::FILE,
         FROM_HERE,
         base::Bind(&CreateOobeCompleteFlagFile));
     return true;
   } else if (value == 0) {
     return false;
   } else {
     // Pref is not set. For compatibility check flag file. It causes blocking
     // IO on UI thread. But it's required for update from old versions.
     base::ThreadRestrictions::ScopedAllowIO allow_io;
-    base::FilePath oobe_complete_flag_file_path = GetOobeCompleteFlagPath();
-    bool file_exists = base::PathExists(oobe_complete_flag_file_path);
+    const base::FilePath oobe_complete_flag_path = GetOobeCompleteFlagPath();
+    bool file_exists = base::PathExists(oobe_complete_flag_path);

[Greg Levin, 2015/09/18 18:49:28]

Is it generally considered desirable or meddling to make little code changes
like this to make things more uniform?

[achuithb, 2015/09/18 19:05:52]

It's fine to clean up as you go along. If you make a large number of mechanical
changes, it's better to use a separate CL so it's not distracting during reviews

     SaveIntegerPreferenceForced(prefs::kDeviceRegistered, file_exists ? 1 : 0);
     return file_exists;
   }
 }
 
 // static
 void StartupUtils::MarkDeviceRegistered(const base::Closure& done_callback) {
   SaveIntegerPreferenceForced(prefs::kDeviceRegistered, 1);
   if (done_callback.is_null()) {
     BrowserThread::PostTask(
@@ skipping 30 matching lines @@
 
 // static
 void StartupUtils::SetInitialLocale(const std::string& locale) {
   if (l10n_util::IsValidLocaleSyntax(locale))
     SaveStringPreferenceForced(prefs::kInitialLocale, locale);
   else
     NOTREACHED();
 }
 
 }  // namespace chromeos