Show Goodies page to new Chromebook users

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 336 matching lines @@
         !session_service->RestoreIfNecessary(std::vector<GURL>())) {
       OpenEmptyWindow(profile->GetOriginalProfile(), desktop_type);
     }
   }
 }
 
 Browser* OpenEmptyWindow(Profile* profile, HostDesktopType desktop_type) {
   Browser* browser = new Browser(
       Browser::CreateParams(Browser::TYPE_TABBED, profile, desktop_type));
   AddTabAt(browser, GURL(), -1, true);
+  // If appropriate, show Goodies page in second tab.
+  GURL goodies_url = profile->ShowingGoodiesPageInNewWindow();
+  if (!goodies_url.is_empty())
+    AddTabAt(browser, goodies_url, 2, false);

[Greg Levin, 2015/09/09 23:20:33]

At the moment, this only shows Goodies when user opens a new, blank browser
window.  It would probably be better to add the second tab the first time they
open *any* browser window.  I could move this code into Navigate() in
browser_navigator.cc, but that felt too... heavy-handed?  Intrusive?  I'd
appreciate a suggestion for how open up a second tab the first time the browser
is shown (subject to restrictions enumerated in
ShowingGoodiesPageInNewWindow()).

[Peter Kasting, 2015/09/10 00:10:05]

I don't know.  Both these locations seem wrong.  How does the code that shows
tabs on firstrun work?  Don't we want to do something similar?

[Greg Levin, 2015/09/10 13:20:21]

The first-run pages I know about are the ChromeVox manual (shown when CV is
active during login) and the Help Center (which is opened instead of Tour app
when not using OFFICIAL_BUILD).  Both of these replace the Tour app, which isn't
an option here; nor do we want to open both the Tour and the Goodies page
simultaneously.  The consensus was to wait until the user manually opened a
browser.  Is there some kind of Navigation observer class I could use?

[Peter Kasting, 2015/09/10 20:39:35]

The bug suggests this should be in the foreground tab, not a background one. 
Implementing that might be easier as you could simply default the home page to
this page and change the homepage once this successfully showed.  Is there
somewhere that explains why you're using an inactive background tab, which is
unlikely to be noticed by most users?

If you need a navigation observer you could ask creis, but I'd rather not hook
every navigation.  It seems like it might be better to instead modify the
startup flow similar to the above, where out of the box the startup pages are
set to "new tab, goodies page" and right after launch we reset the startup
settings.

[Greg Levin, 2015/09/15 00:12:11]

Done (Moved all code into new file / class, which observes the BrowserList).

   browser->window()->Show();
   return browser;
 }
 
 void OpenWindowWithRestoredTabs(Profile* profile,
                                 HostDesktopType host_desktop_type) {
   TabRestoreService* service = TabRestoreServiceFactory::GetForProfile(profile);
   if (service)
     service->RestoreMostRecentEntry(NULL, host_desktop_type);
 }
@@ skipping 917 matching lines @@
                                           browser->host_desktop_type()));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 #endif  // defined(ENABLE_EXTENSIONS)
 
 }  // namespace chrome