Show Goodies page to new Chromebook users

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 91 matching lines @@
 #include "content/public/common/page_zoom.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(OS_ANDROID)
 #include "chrome/browser/media/protected_media_identifier_permission_context.h"
 #include "chrome/browser/media/protected_media_identifier_permission_context_factory.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/locale_change_guard.h"
+#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/preferences.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "components/user_manager/user_manager.h"
 #endif
 
 #if defined(ENABLE_BACKGROUND)
 #include "chrome/browser/background/background_mode_manager.h"
 #endif
 
 #if defined(ENABLE_CONFIGURATION_POLICY)
@@ skipping 35 matching lines @@
 using content::BrowserThread;
 using content::DownloadManagerDelegate;
 
 namespace {
 
 #if defined(ENABLE_SESSION_SERVICE)
 // Delay, in milliseconds, before we explicitly create the SessionService.
 const int kCreateSessionServiceDelayMS = 500;
 #endif
 
+#if defined(OS_CHROMEOS)
+// ChromeOS Goodies page for device's first New Window.
+const char kOOBEGoodiesURL[] =
+    "https://www.google.com/chrome/devices/goodies.html";
+#endif
+
 // Text content of README file created in each profile directory. Both %s
 // placeholders must contain the product name. This is not localizable and hence
 // not in resources.
 const char kReadmeText[] =
     "%s settings and storage represent user-selected preferences and "
     "information and MUST not be extracted, overwritten or modified except "
     "through %s defined APIs.";
 
 // Value written to prefs for EXIT_CRASHED and EXIT_SESSION_ENDED.
 const char kPrefExitTypeCrashed[] = "Crashed";
@@ skipping 1030 matching lines @@
 
   if (GetPrefs()->GetBoolean(prefs::kHomePageIsNewTabPage))
     return GURL(chrome::kChromeUINewTabURL);
   GURL home_page(url_formatter::FixupURL(
       GetPrefs()->GetString(prefs::kHomePage), std::string()));
   if (!home_page.is_valid())
     return GURL(chrome::kChromeUINewTabURL);
   return home_page;
 }
 
+// If conditions enumerated below are met, returns the Oobe Goodies URL for new
+// Chromebooks, and uses pref to mark page as shown.
+GURL ProfileImpl::ShowingGoodiesPageInNewWindow() {

[Greg Levin, 2015/09/09 23:20:33]

This logic could probably go somewhere other than ProfileImpl.  This just seemed
like a convenient way of screening out undesirable profile types (i.e. incognito
& guest) w/o explicit checks.

[anthonyvd, 2015/09/14 13:59:35]

Agreed. Since it's not a profile-specific pref I would be more inclined to move
this to profile_window (where we tend to put similar code related to showing
things to the user e.g. ShouldShow*Tutorial()) and explicitly check for
Incognito and Guest by passing in a Profile*.

[Greg Levin, 2015/09/15 00:12:11]

Done (Moved all code into new file / class).

+// 1. Only show on ChromeOS.
+#if defined(OS_CHROMEOS)
+  PrefService* local_state = g_browser_process->local_state();
+  DCHECK(local_state);
+  // 2. Not previously shown, or otherwise marked as unavailable.
+  if (local_state->GetBoolean(prefs::kCanShowOobeGoodiesPage)) {
+    // 3. Device not enterprise enrolled.
+    if (g_browser_process->platform_part()
+            ->browser_policy_connector_chromeos()
+            ->IsEnterpriseManaged()) {
+      // If it is, no need to ever check again.
+      local_state->SetBoolean(prefs::kCanShowOobeGoodiesPage, false);
+    } else {
+      // (4. Not guest session, or incognito: these both use
+      //     OffTheRecordProfileImpl, not ProfileImpl.)
+      // (5. Not new tab: New tab code doesn't call this function.)
+      local_state->SetBoolean(prefs::kCanShowOobeGoodiesPage, false);
+      return GURL(kOOBEGoodiesURL);
+    }
+  }
+#endif
+  return GURL();
+}
+
 void ProfileImpl::UpdateProfileSupervisedUserIdCache() {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   ProfileInfoCache& cache = profile_manager->GetProfileInfoCache();
   size_t index = cache.GetIndexOfProfileWithPath(GetPath());
   if (index != std::string::npos) {
     std::string supervised_user_id =
         GetPrefs()->GetString(prefs::kSupervisedUserId);
     cache.SetSupervisedUserIdOfProfileAtIndex(index, supervised_user_id);
     ProfileMetrics::UpdateReportedProfilesStatistics(profile_manager);
   }
@@ skipping 72 matching lines @@
 ProfileImpl::CreateDomainReliabilityMonitor(PrefService* local_state) {
   domain_reliability::DomainReliabilityService* service =
       domain_reliability::DomainReliabilityServiceFactory::GetInstance()->
           GetForBrowserContext(this);
   if (!service)
     return scoped_ptr<domain_reliability::DomainReliabilityMonitor>();
 
   return service->CreateMonitor(
       BrowserThread::GetMessageLoopProxyForThread(BrowserThread::IO));
 }