Move Singleton and related structs to namespace base

base/memory/singleton_unittest.cc

Index: base/memory/singleton_unittest.cc
diff --git a/base/memory/singleton_unittest.cc b/base/memory/singleton_unittest.cc
index dbff007ada7ecc27045acdff7082fb448024dab1..edce07c68b22292ea498abd89ba4bd1ed5836eff 100644
--- a/base/memory/singleton_unittest.cc
+++ b/base/memory/singleton_unittest.cc
@@ -5,7 +5,7 @@
 #include "base/at_exit.h"
 #include "base/memory/singleton.h"
 #include "testing/gtest/include/gtest/gtest.h"
-

[rvargas (doing something else), 2015/08/21 19:43:05]

Don't remove this line

+namespace base {

[rvargas (doing something else), 2015/08/21 19:43:05]

I don't like to place tests inside the namespace of the code under test.

When someone is going through a random test to figure out why it is failing,
being as explicit as possible about where the code comes from is a good thing.
It may not be much of an issue in this specific case, but code may come from the
test file's anon namespace, or from the code under test, or from the OS, or from
any other file/library included here (more of an issue for tests outside of
base, but still).

It may be harder to write, but it is easier on the reader.

 namespace {
 
 COMPILE_ASSERT(DefaultSingletonTraits<int>::kRegisterAtExit == true, a);
@@ -147,7 +147,6 @@ CallbackFunc* GetStaticSingleton() {
   return &CallbackSingletonWithStaticTrait::GetInstance()->callback_;
 }
 
-}  // namespace

[rvargas (doing something else), 2015/08/21 19:43:05]

nit: Keep the tests outside of the anon namespace?

 
 class SingletonTest : public testing::Test {
  public:
@@ -285,3 +284,6 @@ TEST_F(SingletonTest, Alignment) {
   EXPECT_ALIGNED(align128, 128);
   EXPECT_ALIGNED(align4096, 4096);
 }
+
+}  // namespace
+}  // namespace base