components/feedback/feedback_uploader_factory.h - Issue 1308823002: Move Singleton and related structs to namespace base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feedback/feedback_uploader_factory.h

Issue 1308823002: Move Singleton and related structs to namespace base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add blank lines Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/media/base/media_message_loop.h ('K') | « components/devtools_discovery/devtools_discovery_manager.cc ('k') | components/feedback/feedback_uploader_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feedback/feedback_uploader_factory.h

diff --git a/components/feedback/feedback_uploader_factory.h b/components/feedback/feedback_uploader_factory.h

index 13e9ee3ff332a6c3b20e21fbc8ddb86c614357f7..ae99d370e0a511c24876e28198824c295335175e 100644

--- a/components/feedback/feedback_uploader_factory.h

+++ b/components/feedback/feedback_uploader_factory.h

@@ -7,7 +7,9 @@

#include "components/keyed_service/content/browser_context_keyed_service_factory.h"

+namespace base {

template<typename T> struct DefaultSingletonTraits;

namespace content {

class BrowserContext;

@@ -28,7 +30,7 @@ class FeedbackUploaderFactory : public BrowserContextKeyedServiceFactory {

content::BrowserContext* context);

private:

- friend struct DefaultSingletonTraits<FeedbackUploaderFactory>;

+ friend struct base::DefaultSingletonTraits<FeedbackUploaderFactory>;

FeedbackUploaderFactory();

~FeedbackUploaderFactory() override;