components/app_modal/javascript_dialog_manager.h - Issue 1308823002: Move Singleton and related structs to namespace base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/javascript_dialog_manager.h

Issue 1308823002: Move Singleton and related structs to namespace base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add blank lines Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/media/base/media_message_loop.h ('K') | « components/app_modal/app_modal_dialog_queue.cc ('k') | components/app_modal/javascript_dialog_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/app_modal/javascript_dialog_manager.h

diff --git a/components/app_modal/javascript_dialog_manager.h b/components/app_modal/javascript_dialog_manager.h

index 7978cddbcadbe91a7f51c065eb5dc1ce582b0058..929e44525e4ba972e16427548fa4943a4c70832f 100644

--- a/components/app_modal/javascript_dialog_manager.h

+++ b/components/app_modal/javascript_dialog_manager.h

@@ -35,7 +35,7 @@ class JavaScriptDialogManager : public content::JavaScriptDialogManager {

scoped_ptr<JavaScriptDialogExtensionsClient> extensions_client);

private:

- friend struct DefaultSingletonTraits<JavaScriptDialogManager>;

+ friend struct base::DefaultSingletonTraits<JavaScriptDialogManager>;

JavaScriptDialogManager();

~JavaScriptDialogManager() override;