ios/chrome/browser/history/web_history_service_factory.h - Issue 1308823002: Move Singleton and related structs to namespace base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/history/web_history_service_factory.h

Issue 1308823002: Move Singleton and related structs to namespace base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl format Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/bookmarks/bookmark_model_factory.h ('K') | « ios/chrome/browser/history/top_sites_factory.cc ('k') | ios/chrome/browser/history/web_history_service_factory.cc » ('j') | ios/chrome/browser/search_engines/template_url_service_factory.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/history/web_history_service_factory.h

diff --git a/ios/chrome/browser/history/web_history_service_factory.h b/ios/chrome/browser/history/web_history_service_factory.h

index 49f5f6325846ebf8a2e01f8778757c2e359c37b6..743f1c890cd1ffa223829a084bc103e68999e165 100644

--- a/ios/chrome/browser/history/web_history_service_factory.h

+++ b/ios/chrome/browser/history/web_history_service_factory.h

@@ -9,9 +9,10 @@

#include "base/memory/scoped_ptr.h"

#include "components/keyed_service/ios/browser_state_keyed_service_factory.h"

+namespace base {

template <typename T>

struct DefaultSingletonTraits;

+} // namespace base

namespace history {

sdefresne 2015/08/27 15:25:12 nit: can you leave a blank line here too

class WebHistoryService;

}

@@ -29,7 +30,7 @@ class WebHistoryServiceFactory : public BrowserStateKeyedServiceFactory {

static WebHistoryServiceFactory* GetInstance();

private:

- friend struct DefaultSingletonTraits<WebHistoryServiceFactory>;

+ friend struct base::DefaultSingletonTraits<WebHistoryServiceFactory>;

WebHistoryServiceFactory();

~WebHistoryServiceFactory() override;