components/app_modal/javascript_dialog_manager.cc - Issue 1308823002: Move Singleton and related structs to namespace base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/javascript_dialog_manager.cc

Issue 1308823002: Move Singleton and related structs to namespace base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl format Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/app_modal/javascript_dialog_manager.h ('k') | components/autofill/core/browser/autofill_country.cc » ('j') | components/keyed_service/content/browser_context_dependency_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/app_modal/javascript_dialog_manager.cc

diff --git a/components/app_modal/javascript_dialog_manager.cc b/components/app_modal/javascript_dialog_manager.cc

index 7892b6ce8de4ff1fe289812b8297b2805e7e3e4e..56de2d08e19b384c7aac146923738b78e2074d0b 100644

--- a/components/app_modal/javascript_dialog_manager.cc

+++ b/components/app_modal/javascript_dialog_manager.cc

@@ -52,7 +52,7 @@ bool ShouldDisplaySuppressCheckbox(

// static

JavaScriptDialogManager* JavaScriptDialogManager::GetInstance() {

- return Singleton<JavaScriptDialogManager>::get();

+ return base::Singleton<JavaScriptDialogManager>::get();

}

void JavaScriptDialogManager::SetNativeDialogFactory(