chrome/browser/favicon/favicon_service_factory.h - Issue 1308823002: Move Singleton and related structs to namespace base

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_service_factory.h

Issue 1308823002: Move Singleton and related structs to namespace base (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git cl format Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/favicon/fallback_icon_service_factory.cc ('k') | chrome/browser/favicon/favicon_service_factory.cc » ('j') | components/keyed_service/content/browser_context_dependency_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/favicon/favicon_service_factory.h

diff --git a/chrome/browser/favicon/favicon_service_factory.h b/chrome/browser/favicon/favicon_service_factory.h

index 6da30f4ffa5a0f8d3caeaf5861c21300abcddf91..ef629fe5b65410136933a66fa90b38772aba6920 100644

--- a/chrome/browser/favicon/favicon_service_factory.h

+++ b/chrome/browser/favicon/favicon_service_factory.h

@@ -8,7 +8,9 @@

#include "components/keyed_service/content/browser_context_keyed_service_factory.h"

#include "components/keyed_service/core/service_access_type.h"

+namespace base {

template <typename T> struct DefaultSingletonTraits;

class Profile;

@@ -33,7 +35,7 @@ class FaviconServiceFactory : public BrowserContextKeyedServiceFactory {

static TestingFactoryFunction GetDefaultFactory();

private:

- friend struct DefaultSingletonTraits<FaviconServiceFactory>;

+ friend struct base::DefaultSingletonTraits<FaviconServiceFactory>;

FaviconServiceFactory();

~FaviconServiceFactory() override;