Fix crash when accessing automation node from stale AX tree

chrome/test/data/extensions/api_test/automation/tests/tabs/close_tab.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var allTests = [
   function testCloseTab() {
     getUrlFromConfig('index.html', function(url) {
       chrome.tabs.create({'url': url}, function(tab) {
         chrome.automation.getTree(function(rootNode) {
           rootNode.addEventListener(EventType.destroyed, function() {
-            // Should get a 'destroyed' event when the tab is closed.
-            // TODO(aboxhall): assert actual cleanup has occurred once
-            // crbug.com/387954 makes it possible.
-            chrome.test.succeed();
+            // Poll until the root node doesn't have a role anymore

[David Tseng, 2015/08/28 22:51:25]

Do we get an event (as to avoid busy waiting?).

[dmazzoni, 2015/08/28 23:02:35]

We get the event immediately before it's destroyed - this is on purpose, so you
can figure out *what* got destroyed. So a setTimeout(0) would work in that
immediately afterwards, that node will be invalid.

I didn't want to depend on setTimeout(0), though, I thought it'd be more robust
to basically say the test busy-waits until the node becomes invalid (which it
should do quickly).

+            // indicating that it really did get cleaned up.
+            function checkSuccess() {
+              if (rootNode.role === undefined)
+                chrome.test.succeed();
+              else
+                window.setTimeout(checkSuccess, 10);
+            }
+            checkSuccess();
           });
           chrome.tabs.remove(tab.id);
         });
       });
     });
   }
 ]
 chrome.test.runTests(allTests);