Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1308773006: FileAPI: Compare expected modification time with delta on file read (Closed)

Created:
5 years, 3 months ago by jsbell
Modified:
5 years, 3 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

FileAPI: Compare expected modification time with delta on file read The File API reader validates that the "expected" modification time - e.g. taken when a user selects a file via <input type=file> matches the "actual" modification time when trying to read. Certain file timestamps (on Windows/NTFS at least) are high enough precision (tenths of microseconds) that an int64->double->int64 round trip through Blink loses bits. Files with these timestamps can't be read! Sample timestamp: 2011-01-01T01:23:45.999999Z (that's a lot of 9s) Make the comparison with an epsilon of 10us. BUG=525088 R=michaeln@chromium.org Committed: https://crrev.com/1d45da203ac9fc8ea3f119edf9030d8e948722a3 Cr-Commit-Position: refs/heads/master@{#346802}

Patch Set 1 #

Patch Set 2 : Remove 20us test since OSX has 1s resolution. ASSERT->EXPECT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
M content/browser/fileapi/local_file_stream_reader_unittest.cc View 1 3 chunks +29 lines, -12 lines 0 comments Download
M storage/browser/fileapi/file_stream_reader.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
michaeln
lgtm (nice find!)
5 years, 3 months ago (2015-09-01 21:36:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308773006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308773006/1
5 years, 3 months ago (2015-09-01 22:27:47 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/107586)
5 years, 3 months ago (2015-09-01 23:42:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308773006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308773006/20001
5 years, 3 months ago (2015-09-02 00:09:45 UTC) #8
jsbell
Fun - per https://en.wikipedia.org/wiki/HFS_Plus the OSX filesystem has only 1s resolution, so trying to touch ...
5 years, 3 months ago (2015-09-02 00:10:40 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-02 00:55:09 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 00:55:47 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d45da203ac9fc8ea3f119edf9030d8e948722a3
Cr-Commit-Position: refs/heads/master@{#346802}

Powered by Google App Engine
This is Rietveld 408576698