Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 1308763004: Revert of Add more components tests to GN build. (Closed)

Created:
5 years, 4 months ago by tommi (sloooow) - chröme
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, jam, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tests5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add more components tests to GN build. (patchset #3 id:40001 of https://codereview.chromium.org/1303013005/ ) Reason for revert: Breaks compile on the Win GN bot: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20GN%20%28dbg%29&number=8108 http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/8108/steps/compile/logs/stdio Original issue's description: > Add more components tests to GN build. > > visitedlink, query_parser, web_cache, autofill > > CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel > TBR=-dpranke@chromium.org > > Committed: https://crrev.com/0eb6b59c463a0aa9dd01956b5542b8cf158e835a > Cr-Commit-Position: refs/heads/master@{#344993} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d5661a88da3abe82351550a7b7aa737bd4b41cfb Cr-Commit-Position: refs/heads/master@{#344999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -64 lines) Patch
M components/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M components/query_parser/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
M components/visitedlink/browser/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M components/visitedlink/common/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M components/visitedlink/renderer/BUILD.gn View 1 chunk +14 lines, -13 lines 0 comments Download
D components/visitedlink/test/BUILD.gn View 1 chunk +0 lines, -16 lines 0 comments Download
M components/web_cache/browser/BUILD.gn View 2 chunks +2 lines, -14 lines 0 comments Download
M components/web_cache/common/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M components/web_cache/renderer/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi (sloooow) - chröme
Created Revert of Add more components tests to GN build.
5 years, 4 months ago (2015-08-23 08:37:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308763004/1
5 years, 4 months ago (2015-08-23 08:37:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-23 08:38:57 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d5661a88da3abe82351550a7b7aa737bd4b41cfb Cr-Commit-Position: refs/heads/master@{#344999}
5 years, 4 months ago (2015-08-23 08:39:42 UTC) #4
brettw
5 years, 4 months ago (2015-08-23 17:26:56 UTC) #5
Message was sent while issue was closed.
LGTM thanks.

Powered by Google App Engine
This is Rietveld 408576698