Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1308763003: X87: Disable test case for X87 because of double register number restriction. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Disable test case for X87 because of double register number restriction. These two test cases introduced by 8525136b require that the double register is >=2. But currently on x87 turbofan implementation only 1 double register is supported. BUG= Committed: https://crrev.com/9726db81993d22eacfeaf52883e06a1a8c442c89 Cr-Commit-Position: refs/heads/master@{#30321}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/compiler/test-run-native-calls.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
chunyang.dai
PTAL.
5 years, 4 months ago (2015-08-21 09:06:15 UTC) #2
titzer
On 2015/08/21 09:06:15, chunyang.dai wrote: > PTAL. I think it would be better to edit ...
5 years, 4 months ago (2015-08-21 10:29:00 UTC) #3
chunyang.dai
Hi, Titzer. thanks for your suggestion. These two test cases already have the following check: ...
5 years, 4 months ago (2015-08-21 16:31:03 UTC) #4
chunyang.dai
Hi, Titzer. I changed these two test cases to use "RegisterConfiguration::ArchDefault()->num_double_registers()" to do the double ...
5 years, 4 months ago (2015-08-24 04:52:26 UTC) #5
titzer
lgtm
5 years, 4 months ago (2015-08-24 07:15:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308763003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308763003/20001
5 years, 4 months ago (2015-08-24 08:19:27 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-24 08:43:54 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 08:44:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9726db81993d22eacfeaf52883e06a1a8c442c89
Cr-Commit-Position: refs/heads/master@{#30321}

Powered by Google App Engine
This is Rietveld 408576698