Fix list of xtbs in policy_templates.grd and remoting_strings.grd.

Fix list of xtbs in policy_templates.grd and remoting_strings.grd.

policy_templates.grd failed to list "fa", while remoting_strings.grd was
missing 11 xtbs. As a result, these strings were missing translations in
several languages.

BUG=518020
Committed: https://crrev.com/9ccdaf6867b7824767e9e4421be1f279c0d6efd8
Cr-Commit-Position: refs/heads/master@{#348736}

[newt (away), 2015-09-09 07:49:17]

newt@chromium.org changed reviewers:
+ bartfab@chromium.org, kelvinp@chromium.org

[newt (away), 2015-09-09 07:49:18]

bartfab: PTAL at policy_templates.grd
kelvinp: PTAL at remoting_strings.grd

[Lambros, 2015-09-09 16:02:20]

lambroslambrou@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2015-09-09 16:02:21]

https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
remoting/resources/remoting_strings.grd:186: <file lang="bn"
path="remoting_strings_bn.xtb"/>
Drive by: Could you please update the Android strings.xml list above? For
example, "bn" and "gu" seem to be missing.

[newt (away), 2015-09-09 16:47:16]

https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
remoting/resources/remoting_strings.grd:186: <file lang="bn"
path="remoting_strings_bn.xtb"/>
On 2015/09/09 16:02:21, Lambros wrote:
> Drive by: Could you please update the Android strings.xml list above? For
> example, "bn" and "gu" seem to be missing.

Chrome for Android doesn't support most of these languages ("bn", "gu", "kn",
"ml", "mr", "ms", "ta", or "te"). Chrome for Android supports a subset of
desktop languages, and the languages listed about in the "if is_android"
statement" are the correct languages (except for one issue with he/iw, which
I've fixed).

Should the remoting app on Android support these languages then?

[Lambros, 2015-09-09 17:20:17]

On 2015/09/09 16:47:16, newt wrote:
>
https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
> File remoting/resources/remoting_strings.grd (right):
> 
>
https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
> remoting/resources/remoting_strings.grd:186: <file lang="bn"
> path="remoting_strings_bn.xtb"/>
> On 2015/09/09 16:02:21, Lambros wrote:
> > Drive by: Could you please update the Android strings.xml list above? For
> > example, "bn" and "gu" seem to be missing.
> 
> Chrome for Android doesn't support most of these languages ("bn", "gu", "kn",
> "ml", "mr", "ms", "ta", or "te"). Chrome for Android supports a subset of
> desktop languages, and the languages listed about in the "if is_android"
> statement" are the correct languages (except for one issue with he/iw, which
> I've fixed).
> 
> Should the remoting app on Android support these languages then?

It should support the same languages Chrome does on Android. I hadn't realized
it was only a subset of the languages supported by Chrome on desktop.

As for he/iw, I think we had a problem with those before. Please take a look at
http://crrev.com/164aa4ea183b18dbad33c2ab19bca9f1936153a2 where we had a problem
with TC not checking in translations for some languages.

[newt (away), 2015-09-09 17:34:55]

On 2015/09/09 17:20:17, Lambros wrote:
> On 2015/09/09 16:47:16, newt wrote:
> >
>
https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
> > File remoting/resources/remoting_strings.grd (right):
> > 
> >
>
https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
> > remoting/resources/remoting_strings.grd:186: <file lang="bn"
> > path="remoting_strings_bn.xtb"/>
> > On 2015/09/09 16:02:21, Lambros wrote:
> > > Drive by: Could you please update the Android strings.xml list above? For
> > > example, "bn" and "gu" seem to be missing.
> > 
> > Chrome for Android doesn't support most of these languages ("bn", "gu",
"kn",
> > "ml", "mr", "ms", "ta", or "te"). Chrome for Android supports a subset of
> > desktop languages, and the languages listed about in the "if is_android"
> > statement" are the correct languages (except for one issue with he/iw, which
> > I've fixed).
> > 
> > Should the remoting app on Android support these languages then?
> 
> It should support the same languages Chrome does on Android. I hadn't realized
> it was only a subset of the languages supported by Chrome on desktop.
> 
> As for he/iw, I think we had a problem with those before. Please take a look
at
> http://crrev.com/164aa4ea183b18dbad33c2ab19bca9f1936153a2 where we had a
problem
> with TC not checking in translations for some languages.

This is a different problem. Currently, the remoting app has no Hebrew
translations because Android looks for Hebrew strings under values-iw, not
values-he.

The change I'm making doesn't regress the bug you linked to. Further, I'm
working on fixing all the bugs like the one you linked to (see
https://docs.google.com/document/d/1Wbj8ynuGS9FpLMInS80AaSoDovjwrbdsoptggRRqU...)

[Lambros, 2015-09-09 18:05:47]

On 2015/09/09 17:34:55, newt wrote:
> On 2015/09/09 17:20:17, Lambros wrote:
> > On 2015/09/09 16:47:16, newt wrote:
> > >
> >
>
https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
> > > File remoting/resources/remoting_strings.grd (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1308743008/diff/20001/remoting/resources/remo...
> > > remoting/resources/remoting_strings.grd:186: <file lang="bn"
> > > path="remoting_strings_bn.xtb"/>
> > > On 2015/09/09 16:02:21, Lambros wrote:
> > > > Drive by: Could you please update the Android strings.xml list above?
For
> > > > example, "bn" and "gu" seem to be missing.
> > > 
> > > Chrome for Android doesn't support most of these languages ("bn", "gu",
> "kn",
> > > "ml", "mr", "ms", "ta", or "te"). Chrome for Android supports a subset of
> > > desktop languages, and the languages listed about in the "if is_android"
> > > statement" are the correct languages (except for one issue with he/iw,
which
> > > I've fixed).
> > > 
> > > Should the remoting app on Android support these languages then?
> > 
> > It should support the same languages Chrome does on Android. I hadn't
realized
> > it was only a subset of the languages supported by Chrome on desktop.
> > 
> > As for he/iw, I think we had a problem with those before. Please take a look
> at
> > http://crrev.com/164aa4ea183b18dbad33c2ab19bca9f1936153a2 where we had a
> problem
> > with TC not checking in translations for some languages.
> 
> This is a different problem. Currently, the remoting app has no Hebrew
> translations because Android looks for Hebrew strings under values-iw, not
> values-he.
> 
> The change I'm making doesn't regress the bug you linked to. Further, I'm
> working on fixing all the bugs like the one you linked to (see
>
https://docs.google.com/document/d/1Wbj8ynuGS9FpLMInS80AaSoDovjwrbdsoptggRRqU...)

Yay! Thanks for taking this on!

[newt (away), 2015-09-10 05:12:51]

friendly ping?

[kelvinp, 2015-09-10 16:45:48]

https://codereview.chromium.org/1308743008/diff/40001/remoting/resources/remo...
File remoting/resources/remoting_strings.grd (left):

https://codereview.chromium.org/1308743008/diff/40001/remoting/resources/remo...
remoting/resources/remoting_strings.grd:183: <!-- TODO(kelvinp): Add a file
entry for each of the newly added locales once the xtb files are checked-in (See
crbug.com/427712). -->
Is this no longer needed?

[newt (away), 2015-09-10 16:50:28]

https://codereview.chromium.org/1308743008/diff/40001/remoting/resources/remo...
File remoting/resources/remoting_strings.grd (left):

https://codereview.chromium.org/1308743008/diff/40001/remoting/resources/remo...
remoting/resources/remoting_strings.grd:183: <!-- TODO(kelvinp): Add a file
entry for each of the newly added locales once the xtb files are checked-in (See
crbug.com/427712). -->
On 2015/09/10 16:45:48, kelvinp wrote:
> Is this no longer needed?

This CL fixes this TODO, so yes, it's no longer needed :)

[bartfab (slow), 2015-09-14 12:52:12]

lgtm

[newt (away), 2015-09-14 17:53:37]

kelvinp or Lambros: ping?

[Lambros, 2015-09-14 19:07:19]

On 2015/09/14 17:53:37, newt wrote:
> kelvinp or Lambros: ping?

remoting/ lgtm - sorry for the slow response.

[newt (away), 2015-09-14 19:52:36]

On 2015/09/14 19:07:19, Lambros wrote:
> On 2015/09/14 17:53:37, newt wrote:
> > kelvinp or Lambros: ping?
> 
> remoting/ lgtm - sorry for the slow response.

Thank you :)

[newt (away), 2015-09-14 19:53:18]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-09-14 19:53:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308743008/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308743008/40001

[commit-bot: I haz the power, 2015-09-14 20:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 20:07:19]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[newt (away), 2015-09-14 20:29:16]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-09-14 20:29:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
bartfab@chromium.org, lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/1308743008/#ps60001
(title: "added empty xtb files")

[commit-bot: I haz the power, 2015-09-14 20:30:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1308743008/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1308743008/60001

[commit-bot: I haz the power, 2015-09-14 22:10:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-14 22:12:07]

Patchset 4 (id:??) landed as
https://crrev.com/9ccdaf6867b7824767e9e4421be1f279c0d6efd8
Cr-Commit-Position: refs/heads/master@{#348736}

[commit-bot: I haz the power, 2015-09-23 12:37:56]

Patchset 4 (id:??) landed as
https://crrev.com/9ccdaf6867b7824767e9e4421be1f279c0d6efd8
Cr-Commit-Position: refs/heads/master@{#348736}