Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 1308743005: X87: Crankshaft is now able to compile top level code even if there is a ScriptContext. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Crankshaft is now able to compile top level code even if there is a ScriptContext. port 29ebcc32052d486cbc1933ac4738aa5cb68aa851 (r30496). original commit message: This CL introduces HPrologue instruction which does the context allocation work and supports deoptimization. BUG= Committed: https://crrev.com/c0c3d866fb824290c24d4c2a14414019d844515f Cr-Commit-Position: refs/heads/master@{#30606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 3 chunks +20 lines, -13 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 3 months ago (2015-09-06 10:19:34 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-07 07:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308743005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308743005/1
5 years, 3 months ago (2015-09-07 07:17:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 07:48:55 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 07:49:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0c3d866fb824290c24d4c2a14414019d844515f
Cr-Commit-Position: refs/heads/master@{#30606}

Powered by Google App Engine
This is Rietveld 408576698