Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1308713007: Revert of Append playinline=chrome_inline to the store referrer on native app banner install. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
dominickn, gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Append playinline=chrome_inline to the store referrer on native app banner install. (patchset #2 id:60001 of https://codereview.chromium.org/1312343003/ ) Reason for revert: Broke org.chromium.chrome.browser.banners.AppBannerManagerTest according to dominickn: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/29822 http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/21895 Original issue's description: > Append playinline=chrome_inline to the store referrer on native app banner install. > > This CL appends a marker to the store referrer to show that a native app > install was triggered from the Chrome inline flow. This marker is always > sent to the store, even if the site triggering an install does not > specify a referrer. > > BUG=503226 > > Committed: https://crrev.com/e55eabaaa89d6b01dd5ab9984b6d670468ca9e72 > Cr-Commit-Position: refs/heads/master@{#345730} TBR=dfalcantara@chromium.org,dominickn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=503226 Committed: https://crrev.com/35a21829d492dca8c61f7310f5fab36597ba0655 Cr-Commit-Position: refs/heads/master@{#345812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M chrome/browser/android/banners/app_banner_manager_android.cc View 2 chunks +1 line, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Append playinline=chrome_inline to the store referrer on native app banner install.
5 years, 3 months ago (2015-08-27 06:28:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308713007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308713007/1
5 years, 3 months ago (2015-08-27 06:28:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 06:28:46 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 06:29:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35a21829d492dca8c61f7310f5fab36597ba0655
Cr-Commit-Position: refs/heads/master@{#345812}

Powered by Google App Engine
This is Rietveld 408576698