Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1308713005: Unship TypedArray.map method (Closed)

Created:
5 years, 3 months ago by Dan Ehrenberg
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev, amineer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unship TypedArray.map method The TypedArray.map method breaks a particular Chrome app, which conditionally monkey-patches in an unrelated function with the same name, but only if that property does not exist. The developer already has a fix, but it is not deployed to all contexts yet. For now, this patch unships the TypedArray.map method, but the longer-term solution will be to work with the developer to deploy the fix to the Turbulenz game engine. BUG=chromium:524392 LOG=Y R=adamk

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/harmony-typedarray.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Dan Ehrenberg
5 years, 3 months ago (2015-08-25 18:57:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308713005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308713005/1
5 years, 3 months ago (2015-08-25 18:57:23 UTC) #3
adamk
lgtm % nits if this is the approach we want to take, but please wait ...
5 years, 3 months ago (2015-08-25 20:06:25 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-25 20:11:22 UTC) #6
seththompson
5 years, 3 months ago (2015-08-25 20:23:04 UTC) #7
As per the issue thread,
https://code.google.com/p/chromium/issues/detail?id=524392, let's not unship
`map`.

Thanks for having this ready, though, Dan.

Powered by Google App Engine
This is Rietveld 408576698