Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4174)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pulse
Patch Set: Address comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_dialogs.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 6bc2998691073c31a7d531fb771529b632936292..d5fc14b11c313ea8b648ae8d668e4ddc47158402 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -35,6 +35,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_command_controller.h"
#include "chrome/browser/ui/browser_commands.h"
+#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/ui/browser_instant_controller.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_window_state.h"
@@ -96,6 +97,7 @@
#import "ui/base/cocoa/nsview_additions.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/l10n/l10n_util_mac.h"
+#import "ui/gfx/mac/coordinate_conversion.h"
#include "ui/gfx/mac/scoped_cocoa_disable_screen_updates.h"
using bookmarks::BookmarkModel;
@@ -1767,8 +1769,18 @@ using content::WebContents;
// Show the bookmark bubble (e.g. user just clicked on the STAR).
- (void)showBookmarkBubbleForURL:(const GURL&)url
alreadyBookmarked:(BOOL)alreadyMarked {
- if (!bookmarkBubbleObserver_.get()) {
- bookmarkBubbleObserver_.reset(new BookmarkBubbleObserverCocoa(self));
+ if (bookmarkBubbleObserver_.get())
+ return;
+
+ bookmarkBubbleObserver_.reset(new BookmarkBubbleObserverCocoa(self));
+
+ if (chrome::ToolkitViewsDialogsEnabled()) {
+ chrome::ShowBookmarkBubbleViewsAtPoint(
+ gfx::ScreenPointFromNSPoint(
+ [[self window] convertBaseToScreen:[self bookmarkBubblePoint]]),
+ [[self window] contentView], bookmarkBubbleObserver_.get(),
+ browser_.get(), url, alreadyMarked);
+ } else {
BookmarkModel* model =
BookmarkModelFactory::GetForProfile(browser_->profile());
bookmarks::ManagedBookmarkService* managed =
@@ -1782,8 +1794,8 @@ using content::WebContents;
node:node
alreadyBookmarked:alreadyMarked];
[bookmarkBubbleController_ showWindow:self];
- DCHECK(bookmarkBubbleObserver_);
}
+ DCHECK(bookmarkBubbleObserver_);
}
- (void)bookmarkBubbleClosed {
« no previous file with comments | « chrome/browser/ui/browser_dialogs.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698