Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5658)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pulse
Patch Set: Address comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
index 00cfdcc804b9433e07eea44249988608305429d6..9f35f6c6b72c866fea4bd1a1ffcc67685ba699f2 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
@@ -36,7 +36,11 @@ class BookmarkBubbleView : public views::BubbleDelegateView,
public views::ButtonListener,
public views::ComboboxListener {
public:
+ // If |anchor_view| is null, |anchor_rect| is used to anchor the bubble and
+ // |parent_window| is used to ensure the bubble closes if the parent closes.
static void ShowBubble(views::View* anchor_view,
+ const gfx::Rect& anchor_rect,
+ gfx::NativeView parent_window,
bookmarks::BookmarkBubbleObserver* observer,
scoped_ptr<BookmarkBubbleDelegate> delegate,
Profile* profile,

Powered by Google App Engine
This is Rietveld 408576698