chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h - Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pulse

Patch Set: Pull non-Views parts out to https://codereview.chromium.org/1308293002/ Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser_dialogs.h ('K') | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

index 00cfdcc804b9433e07eea44249988608305429d6..9f35f6c6b72c866fea4bd1a1ffcc67685ba699f2 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

@@ -36,7 +36,11 @@ class BookmarkBubbleView : public views::BubbleDelegateView,

public views::ButtonListener,

public views::ComboboxListener {

public:

+ // If |anchor_view| is null, |anchor_rect| is used to anchor the bubble and

+ // |parent_window| is used to ensure the bubble closes if the parent closes.

static void ShowBubble(views::View* anchor_view,

+ const gfx::Rect& anchor_rect,

+ gfx::NativeView parent_window,

bookmarks::BookmarkBubbleObserver* observer,

scoped_ptr<BookmarkBubbleDelegate> delegate,

Profile* profile,