[Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs.

chrome/browser/ui/views/browser_dialogs_views_mac.cc

Index: chrome/browser/ui/views/browser_dialogs_views_mac.cc
diff --git a/chrome/browser/ui/views/browser_dialogs_views_mac.cc b/chrome/browser/ui/views/browser_dialogs_views_mac.cc
index 61a5f8762a4355ce8eb694784fd9e11f7389fcc2..04787a3f612cb97cac8984ade4dbcc188eb2f60e 100644
--- a/chrome/browser/ui/views/browser_dialogs_views_mac.cc
+++ b/chrome/browser/ui/views/browser_dialogs_views_mac.cc
@@ -4,6 +4,9 @@
 
 #include "chrome/browser/ui/browser_dialogs.h"
 
+#include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h"
 
 // This file provides definitions of desktop browser dialog-creation methods for
@@ -24,4 +27,18 @@ void ShowWebsiteSettingsBubbleViewsAtPoint(const gfx::Point& anchor_point,
                                       profile, web_contents, url, ssl);
 }
 
+void ShowBookmarkBubbleViewsAtPoint(const gfx::Point& anchor_point,
+                                    gfx::NativeView parent,
+                                    bookmarks::BookmarkBubbleObserver* observer,
+                                    Browser* browser,
+                                    const GURL& url,
+                                    bool already_bookmarked) {
+  scoped_ptr<BookmarkBubbleDelegate> delegate;
+  delegate.reset(new BookmarkBubbleSignInDelegate(browser));

[tapted, 2015/08/21 07:19:18]

Comment about this? (shouldn't Cocoa have one of these too? - should it get
passed in?)

[jackhou1, 2015/08/24 08:22:04]

Done. 

This is the prompt at the bottom of the bookmark bubble saying "Sign in to sync
your bookmarks". I think Cocoa just doesn't have this.

[jackhou1, 2015/08/25 04:55:39]

It turns out on Cocoa the sign-in prompt is managed by
BookmarkSyncPromoController, which the controller for that NSView. I don't think
it makes sense to make it use BookmarkBubbleSignInDelegate, there's not much to
gain.

[tapted, 2015/08/25 05:56:48]

Acknowledged. I guess it's the views code that's weird, so no changes are needed
here.

That is, it looks like BookmarkBubbleSignInDelegate is the only
BookmarkBubbleDelegate and only views code uses BookmarkBubbleDelegate even
though it's in chrome/browser/ui/bookmarks instead of
chrome/browser/ui/views/bookmarks

So BookmarkSyncPromoView doesn't really need a delegate -- it could just invoke
the signin stuff directly, except that would confuse the testing that's
happening in bookmark_sync_promo_view_unittest.cc.

Maybe the testing could remain as-is if the BookmarkBubbleSignInDelegate was
simply moved into BookmarkBubbleView -- doesn't seem necessary to have it tied
to BrowserView. But all that's orthogonal to this CL.

+
+  BookmarkBubbleView::ShowBubble(nullptr, gfx::Rect(anchor_point, gfx::Size()),
+                                 parent, observer, delegate.Pass(),
+                                 browser->profile(), url, !already_bookmarked);
+}
+
 }  // namespace chrome