Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: chrome/browser/ui/views/browser_dialogs_views_mac.cc

Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pulse
Patch Set: Address comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser_dialogs.h" 5 #include "chrome/browser/ui/browser_dialogs.h"
6 6
7 #include "chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate.h"
8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h"
7 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h " 10 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h "
8 11
9 // This file provides definitions of desktop browser dialog-creation methods for 12 // This file provides definitions of desktop browser dialog-creation methods for
10 // Mac where a Cocoa browser is using Views dialogs. I.e. it is included in the 13 // Mac where a Cocoa browser is using Views dialogs. I.e. it is included in the
11 // Cocoa build and definitions under chrome/browser/ui/cocoa may select at 14 // Cocoa build and definitions under chrome/browser/ui/cocoa may select at
12 // runtime whether to show a Cocoa dialog, or the toolkit-views dialog defined 15 // runtime whether to show a Cocoa dialog, or the toolkit-views dialog defined
13 // here (declared in browser_dialogs.h). 16 // here (declared in browser_dialogs.h).
14 17
15 namespace chrome { 18 namespace chrome {
16 19
17 void ShowWebsiteSettingsBubbleViewsAtPoint(const gfx::Point& anchor_point, 20 void ShowWebsiteSettingsBubbleViewsAtPoint(const gfx::Point& anchor_point,
18 Profile* profile, 21 Profile* profile,
19 content::WebContents* web_contents, 22 content::WebContents* web_contents,
20 const GURL& url, 23 const GURL& url,
21 const content::SSLStatus& ssl) { 24 const content::SSLStatus& ssl) {
22 WebsiteSettingsPopupView::ShowPopup(nullptr, 25 WebsiteSettingsPopupView::ShowPopup(nullptr,
23 gfx::Rect(anchor_point, gfx::Size()), 26 gfx::Rect(anchor_point, gfx::Size()),
24 profile, web_contents, url, ssl); 27 profile, web_contents, url, ssl);
25 } 28 }
26 29
30 void ShowBookmarkBubbleViewsAtPoint(const gfx::Point& anchor_point,
31 gfx::NativeView parent,
32 bookmarks::BookmarkBubbleObserver* observer,
33 Browser* browser,
34 const GURL& url,
35 bool already_bookmarked) {
36 // The Views dialog may prompt for sign in.
37 scoped_ptr<BookmarkBubbleDelegate> delegate(
38 new BookmarkBubbleSignInDelegate(browser));
39
40 BookmarkBubbleView::ShowBubble(nullptr, gfx::Rect(anchor_point, gfx::Size()),
41 parent, observer, delegate.Pass(),
42 browser->profile(), url, already_bookmarked);
43 }
44
27 } // namespace chrome 45 } // namespace chrome
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc ('k') | chrome/browser/ui/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698