Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1308713002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pulse
Patch Set: Pull non-Views parts out to https://codereview.chromium.org/1308293002/ Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 5 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <numeric> 8 #include <numeric>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 17 matching lines...) Expand all
28 #include "chrome/browser/profiles/profile_manager.h" 28 #include "chrome/browser/profiles/profile_manager.h"
29 #include "chrome/browser/profiles/profiles_state.h" 29 #include "chrome/browser/profiles/profiles_state.h"
30 #include "chrome/browser/themes/theme_service.h" 30 #include "chrome/browser/themes/theme_service.h"
31 #include "chrome/browser/themes/theme_service_factory.h" 31 #include "chrome/browser/themes/theme_service_factory.h"
32 #include "chrome/browser/translate/chrome_translate_client.h" 32 #include "chrome/browser/translate/chrome_translate_client.h"
33 #include "chrome/browser/ui/bookmarks/bookmark_editor.h" 33 #include "chrome/browser/ui/bookmarks/bookmark_editor.h"
34 #include "chrome/browser/ui/bookmarks/bookmark_utils.h" 34 #include "chrome/browser/ui/bookmarks/bookmark_utils.h"
35 #include "chrome/browser/ui/browser.h" 35 #include "chrome/browser/ui/browser.h"
36 #include "chrome/browser/ui/browser_command_controller.h" 36 #include "chrome/browser/ui/browser_command_controller.h"
37 #include "chrome/browser/ui/browser_commands.h" 37 #include "chrome/browser/ui/browser_commands.h"
38 #include "chrome/browser/ui/browser_dialogs.h"
38 #include "chrome/browser/ui/browser_instant_controller.h" 39 #include "chrome/browser/ui/browser_instant_controller.h"
39 #include "chrome/browser/ui/browser_list.h" 40 #include "chrome/browser/ui/browser_list.h"
40 #include "chrome/browser/ui/browser_window_state.h" 41 #include "chrome/browser/ui/browser_window_state.h"
41 #import "chrome/browser/ui/cocoa/background_gradient_view.h" 42 #import "chrome/browser/ui/cocoa/background_gradient_view.h"
42 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h" 43 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
43 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.h" 44 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_observer_cocoa.h"
44 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.h" 45 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_editor_controller.h"
45 #import "chrome/browser/ui/cocoa/browser_window_cocoa.h" 46 #import "chrome/browser/ui/cocoa/browser_window_cocoa.h"
46 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h" 47 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
47 #import "chrome/browser/ui/cocoa/browser_window_layout.h" 48 #import "chrome/browser/ui/cocoa/browser_window_layout.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 #include "components/translate/core/browser/translate_manager.h" 90 #include "components/translate/core/browser/translate_manager.h"
90 #include "components/translate/core/browser/translate_ui_delegate.h" 91 #include "components/translate/core/browser/translate_ui_delegate.h"
91 #include "components/web_modal/web_contents_modal_dialog_manager.h" 92 #include "components/web_modal/web_contents_modal_dialog_manager.h"
92 #include "content/public/browser/render_view_host.h" 93 #include "content/public/browser/render_view_host.h"
93 #include "content/public/browser/render_widget_host_view.h" 94 #include "content/public/browser/render_widget_host_view.h"
94 #include "content/public/browser/web_contents.h" 95 #include "content/public/browser/web_contents.h"
95 #import "ui/base/cocoa/cocoa_base_utils.h" 96 #import "ui/base/cocoa/cocoa_base_utils.h"
96 #import "ui/base/cocoa/nsview_additions.h" 97 #import "ui/base/cocoa/nsview_additions.h"
97 #include "ui/base/l10n/l10n_util.h" 98 #include "ui/base/l10n/l10n_util.h"
98 #include "ui/base/l10n/l10n_util_mac.h" 99 #include "ui/base/l10n/l10n_util_mac.h"
100 #import "ui/gfx/mac/coordinate_conversion.h"
99 #include "ui/gfx/mac/scoped_cocoa_disable_screen_updates.h" 101 #include "ui/gfx/mac/scoped_cocoa_disable_screen_updates.h"
100 102
101 using bookmarks::BookmarkModel; 103 using bookmarks::BookmarkModel;
102 using bookmarks::BookmarkNode; 104 using bookmarks::BookmarkNode;
103 using l10n_util::GetStringUTF16; 105 using l10n_util::GetStringUTF16;
104 using l10n_util::GetNSStringWithFixup; 106 using l10n_util::GetNSStringWithFixup;
105 using l10n_util::GetNSStringFWithFixup; 107 using l10n_util::GetNSStringFWithFixup;
106 108
107 // ORGANIZATION: This is a big file. It is (in principle) organized as follows 109 // ORGANIZATION: This is a big file. It is (in principle) organized as follows
108 // (in order): 110 // (in order):
(...skipping 1651 matching lines...) Expand 10 before | Expand all | Expand 10 after
1760 alignment:alignment]; 1762 alignment:alignment];
1761 } 1763 }
1762 1764
1763 - (NSPoint)bookmarkBubblePoint { 1765 - (NSPoint)bookmarkBubblePoint {
1764 return [toolbarController_ bookmarkBubblePoint]; 1766 return [toolbarController_ bookmarkBubblePoint];
1765 } 1767 }
1766 1768
1767 // Show the bookmark bubble (e.g. user just clicked on the STAR). 1769 // Show the bookmark bubble (e.g. user just clicked on the STAR).
1768 - (void)showBookmarkBubbleForURL:(const GURL&)url 1770 - (void)showBookmarkBubbleForURL:(const GURL&)url
1769 alreadyBookmarked:(BOOL)alreadyMarked { 1771 alreadyBookmarked:(BOOL)alreadyMarked {
1770 if (!bookmarkBubbleObserver_.get()) { 1772 if (bookmarkBubbleObserver_.get())
1771 bookmarkBubbleObserver_.reset( 1773 return;
1772 new bookmarks::BookmarkBubbleObserverCocoa(self)); 1774
1775 bookmarkBubbleObserver_.reset(
1776 new bookmarks::BookmarkBubbleObserverCocoa(self));
1777
1778 if (chrome::ToolkitViewsDialogsEnabled()) {
1779 chrome::ShowBookmarkBubbleViewsAtPoint(
1780 gfx::ScreenPointFromNSPoint(
1781 [[self window] convertBaseToScreen:[self bookmarkBubblePoint]]),
1782 [[self window] contentView], bookmarkBubbleObserver_.get(),
1783 browser_.get(), url, alreadyMarked);
1784 } else {
1773 BookmarkModel* model = 1785 BookmarkModel* model =
1774 BookmarkModelFactory::GetForProfile(browser_->profile()); 1786 BookmarkModelFactory::GetForProfile(browser_->profile());
1775 bookmarks::ManagedBookmarkService* managed = 1787 bookmarks::ManagedBookmarkService* managed =
1776 ManagedBookmarkServiceFactory::GetForProfile(browser_->profile()); 1788 ManagedBookmarkServiceFactory::GetForProfile(browser_->profile());
1777 const BookmarkNode* node = model->GetMostRecentlyAddedUserNodeForURL(url); 1789 const BookmarkNode* node = model->GetMostRecentlyAddedUserNodeForURL(url);
1778 bookmarkBubbleController_ = [[BookmarkBubbleController alloc] 1790 bookmarkBubbleController_ = [[BookmarkBubbleController alloc]
1779 initWithParentWindow:[self window] 1791 initWithParentWindow:[self window]
1780 observer:bookmarkBubbleObserver_.get() 1792 observer:bookmarkBubbleObserver_.get()
1781 managed:managed 1793 managed:managed
1782 model:model 1794 model:model
1783 node:node 1795 node:node
1784 alreadyBookmarked:alreadyMarked]; 1796 alreadyBookmarked:alreadyMarked];
1785 [bookmarkBubbleController_ showWindow:self]; 1797 [bookmarkBubbleController_ showWindow:self];
1786 DCHECK(bookmarkBubbleObserver_);
1787 } 1798 }
1799 DCHECK(bookmarkBubbleObserver_);
1788 } 1800 }
1789 1801
1790 - (void)bookmarkBubbleClosed { 1802 - (void)bookmarkBubbleClosed {
1791 // Nil out the weak bookmark bubble controller reference. 1803 // Nil out the weak bookmark bubble controller reference.
1792 bookmarkBubbleController_ = nil; 1804 bookmarkBubbleController_ = nil;
1793 bookmarkBubbleObserver_.reset(); 1805 bookmarkBubbleObserver_.reset();
1794 } 1806 }
1795 1807
1796 // Handle the editBookmarkNode: action sent from bookmark bubble controllers. 1808 // Handle the editBookmarkNode: action sent from bookmark bubble controllers.
1797 - (void)editBookmarkNode:(id)sender { 1809 - (void)editBookmarkNode:(id)sender {
(...skipping 464 matching lines...) Expand 10 before | Expand all | Expand 10 after
2262 2274
2263 - (BOOL)supportsBookmarkBar { 2275 - (BOOL)supportsBookmarkBar {
2264 return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR]; 2276 return [self supportsWindowFeature:Browser::FEATURE_BOOKMARKBAR];
2265 } 2277 }
2266 2278
2267 - (BOOL)isTabbedWindow { 2279 - (BOOL)isTabbedWindow {
2268 return browser_->is_type_tabbed(); 2280 return browser_->is_type_tabbed();
2269 } 2281 }
2270 2282
2271 @end // @implementation BrowserWindowController(WindowType) 2283 @end // @implementation BrowserWindowController(WindowType)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698