include/effects/SkBlurImageFilter.h - Issue 1308703007: Fix filter primitive bounds computations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkBlurImageFilter.h

Issue 1308703007: Fix filter primitive bounds computations. (Closed) Base URL: https://skia.googlesource.com/skia.git@saveLayer-bounds-not-transformed

Patch Set: 100-col fixes Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/effects/SkBlurImageFilter.h

diff --git a/include/effects/SkBlurImageFilter.h b/include/effects/SkBlurImageFilter.h

index c7193a435f09918be7c86973f74b43e23da5d52a..4b8fa55829337ef0874cf58cfa9423969e4a0b06 100644

--- a/include/effects/SkBlurImageFilter.h

+++ b/include/effects/SkBlurImageFilter.h

@@ -27,7 +27,8 @@ protected:

void flatten(SkWriteBuffer&) const override;

bool onFilterImage(Proxy*, const SkBitmap& src, const Context&, SkBitmap* result,

SkIPoint* offset) const override;

- bool onFilterBounds(const SkIRect& src, const SkMatrix&, SkIRect* dst) const override;

+ void onFilterNodeBounds(const SkIRect& src, const SkMatrix&,

+ SkIRect* dst, MapDirection direction) const override;

reed1 2015/12/09 16:11:41 trivial nit: don't need 'direction', since the typ

Stephen White 2015/12/09 17:02:57 Done (here and elsewhere).

bool canFilterImageGPU() const override { return true; }

bool filterImageGPU(Proxy* proxy, const SkBitmap& src, const Context& ctx, SkBitmap* result,

SkIPoint* offset) const override;

« include/core/SkImageFilter.h ('K') | « include/core/SkImageFilter.h ('k') | include/effects/SkDisplacementMapEffect.h » ('j') | no next file with comments »