Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1308693014: [Interpreter] Ensure that implicit return undefined is generated. (Closed)

Created:
5 years, 3 months ago by rmcilroy
Modified:
5 years, 3 months ago
Reviewers:
oth, Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Ensure that implicit return undefined is generated. When there is no explicit return we need to generate an implicit return undefined. BUG=v8:4280 LOG=N Committed: https://crrev.com/c9f0368adda0436569076065367e59320327ca00 Cr-Commit-Position: refs/heads/master@{#30639}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/interpreter/bytecode-array-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308693014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308693014/1
5 years, 3 months ago (2015-09-07 23:25:15 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-07 23:50:29 UTC) #4
rmcilroy
Orion, please have a look, thanks. Michi for owner stamp (comments welcome)
5 years, 3 months ago (2015-09-08 08:19:24 UTC) #6
Michael Starzinger
I am not an owner of anything in this CL, but I am happy to ...
5 years, 3 months ago (2015-09-08 08:25:10 UTC) #7
rmcilroy
> I am not an owner of anything in this CL, but I am happy ...
5 years, 3 months ago (2015-09-08 09:41:59 UTC) #8
oth
On 2015/09/08 09:41:59, rmcilroy wrote: > > I am not an owner of anything in ...
5 years, 3 months ago (2015-09-08 10:38:59 UTC) #9
Michael Starzinger
LGTM (rubber-stamped).
5 years, 3 months ago (2015-09-08 12:42:07 UTC) #10
rmcilroy
> An alternative would be to append "Ldar undefined; return" in ToBytecodeArray > and add ...
5 years, 3 months ago (2015-09-08 14:14:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308693014/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308693014/20001
5 years, 3 months ago (2015-09-08 14:15:23 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-08 15:02:52 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 15:03:07 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9f0368adda0436569076065367e59320327ca00
Cr-Commit-Position: refs/heads/master@{#30639}

Powered by Google App Engine
This is Rietveld 408576698