Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1308693013: Pretty print field trials (Closed)

Created:
5 years, 3 months ago by Steven Holte
Modified:
5 years, 3 months ago
Reviewers:
felt, danduong
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -295 lines) Patch
M testing/variations/PRESUBMIT.py View 1 4 chunks +49 lines, -1 line 0 comments Download
M testing/variations/fieldtrial_testing_config_android.json View 1 2 3 8 chunks +171 lines, -175 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_chromeos.json View 3 chunks +14 lines, -14 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_ios.json View 1 chunk +12 lines, -12 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 2 5 chunks +23 lines, -23 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 2 6 chunks +31 lines, -31 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 2 6 chunks +39 lines, -39 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Steven Holte
5 years, 3 months ago (2015-09-02 21:27:34 UTC) #2
felt
lgtm, this is great :D
5 years, 3 months ago (2015-09-03 18:57:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308693013/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308693013/40001
5 years, 3 months ago (2015-09-03 20:48:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/48957)
5 years, 3 months ago (2015-09-03 21:44:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308693013/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308693013/40001
5 years, 3 months ago (2015-09-03 21:55:29 UTC) #9
commit-bot: I haz the power
Failed to apply patch for testing/variations/fieldtrial_testing_config_chromeos.json: While running git apply --index -3 -p1; error: patch ...
5 years, 3 months ago (2015-09-03 22:37:12 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2d8d0e8d7c75b73649de2c79a2c4ddadf9585522 Cr-Commit-Position: refs/heads/master@{#347841}
5 years, 3 months ago (2015-09-09 00:09:12 UTC) #13
Steven Holte
5 years, 3 months ago (2015-09-09 00:10:04 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
2d8d0e8d7c75b73649de2c79a2c4ddadf9585522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698